test: fix test failures on Windows #175
Conversation
StoneDot
force-pushed
the
fix-windows-trycmd
branch
from
6ec7bf5 to
20ca02a
Compare
|
We need to consider two thing for Windows.
We can use Windows image on GitHub Actions. So we can iterate test cycle as well as Linux.
We will need to update snapshot when the command format is updated as well as Linux. Important thing is how to update snapshot. The idea is that we make a comment like |
|
Based on the feedback from ryota-ksakamoto, I will include mentioned feature into this PR. |
StoneDot
force-pushed
the
fix-windows-trycmd
branch
5 times, most recently
from
8ed0b37 to
ae29b1c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
StoneDot
force-pushed
the
fix-windows-trycmd
branch
from
ae29b1c to
3a063d3
Compare
|
The sample of an execution of the bot; |
StoneDot
force-pushed
the
fix-windows-trycmd
branch
6 times, most recently
from
b1c0f35 to
aa7e8f1
Compare
StoneDot
force-pushed
the
fix-windows-trycmd
branch
4 times, most recently
from
cac7c97 to
864555c
Compare
StoneDot
force-pushed
the
fix-windows-trycmd
branch
3 times, most recently
from
e6be368 to
0815603
Compare
| @@ -27,7 +27,7 @@ jobs: | |||
| os: macos-latest | |||
| target: x86_64-apple-darwin | |||
| - name: windows | |||
| os: windows-2019 | |||
| os: windows-2022 | |||
There was a problem hiding this comment.
Why do we use windows-2022 rather than windows-latest? As I can see, .github/workflows/bot.yml use windows-latest also other platform use -latest as well.
There was a problem hiding this comment.
Thank you for mentioning it. Because I believe that a stable binary generation is preferable, I specify windows-2022 instead of windows-latest. However, I did not notice that other platforms use the latest version. It seems that changing to latest is preferable for unification. Thus, I modified it as window-latest. I have created an issue to discuss the preferable version to support at #186.
On the other hand, I do not have a good reason for using windows-latest in bot.yml. Do you have any opinion regarding bot.yml?
There was a problem hiding this comment.
From my opinion, we need to unify image on all of workflow. Because, the snapshot is actually not to relate building binary itself but if the image is different we are hard to identify the cause when any issue occur.
So would you mind if we use windows-2022 instead of windows-latest on other workflow for now and will discuss it on the issue?
There was a problem hiding this comment.
Thanks. I think your opinion makes sense. Due to the scope of this PR, I changed os to windows-2022 for both CI and bots for the Windows platform. Let's discuss this within #186 about other platforms.
StoneDot
force-pushed
the
fix-windows-trycmd
branch
2 times, most recently
from
6543f37 to
ef179f9
Compare
|
@ryota-sakamoto Thank you for reviewing it. Could you check the modifications and comments? |
StoneDot
force-pushed
the
fix-windows-trycmd
branch
from
ef179f9 to
fa4bd97
Compare
Issue #, if available:
#159
Description of changes:
This PR fixes the issue of test failures on Windows by introducing separate snapshots for Windows.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.