Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag for developing dy admin apply #156

Merged
merged 1 commit into from
Oct 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/cmd.rs
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,14 @@ pub enum AdminSub {
#[structopt(subcommand)]
target_type: DeleteSub,
},

/// [WIP] Create or update DynamoDB tables based on CloudFormation template files (.cfn.yml).
#[structopt(setting(structopt::clap::AppSettings::Hidden))]
StoneDot marked this conversation as resolved.
Show resolved Hide resolved
Apply {
/// Try features under development
#[structopt(long)]
StoneDot marked this conversation as resolved.
Show resolved Hide resolved
dev: bool,
},
/*
/// Compare the desired and current state of a DynamoDB table.
#[structopt()]
Expand All @@ -435,11 +443,6 @@ pub enum AdminSub {
name: String,
},

/// Create or update DynamoDB tables based on CloudFormation template files (.cfn.yml).
#[structopt()]
Apply {
},

/// Delete all items in the target table.
#[structopt()]
Truncate {
Expand Down
7 changes: 7 additions & 0 deletions src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,13 @@ async fn dispatch(context: &mut app::Context, subcommand: cmd::Sub) -> Result<()
yes,
} => control::delete_table(context.clone(), table_name_to_delete, yes).await,
},
cmd::AdminSub::Apply { dev } => {
if dev {
todo!()
} else {
println!("not yet implemented")
}
}
},

cmd::Sub::Scan {
Expand Down
40 changes: 40 additions & 0 deletions tests/apply.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
/*
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

pub mod util;

use assert_cmd::prelude::*; // Add methods on commands
use predicates::prelude::*; // Used for writing assertions

#[tokio::test]
async fn test_apply() -> Result<(), Box<dyn std::error::Error>> {
let tm = util::setup().await?;
let mut c = tm.command()?;
let cmd = c.args(&["--region", "local", "admin", "apply"]);
cmd.assert()
.success()
.stdout(predicate::str::contains("not yet implemented"));
Ok(())
}

#[tokio::test]
#[should_panic(expected = "not yet implemented")]
async fn test_apply_with_dev() {
let tm = util::setup().await.unwrap();
let mut c = tm.command().unwrap();
let cmd = c.args(&["--region", "local", "admin", "apply", "--dev"]);
cmd.unwrap();
}