Add Scheduler and TokenBucket metrics #125
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajtodd
reviewed
Oct 8, 2025
| pub(crate) struct TokenBucketMetrics { | ||
| max_tokens: u64, | ||
| available_tokens: UpDownCounter, | ||
| token_wait_time: Histogram, |
There was a problem hiding this comment.
I'm not sure if this will be meaningful or not given permit requests come with different token amounts requested.
There was a problem hiding this comment.
I wonder if tracking percentage of available tokens over time or something would be more useful?
aws-sdk-s3-transfer-manager/src/middleware/limit/concurrency/future.rs
Outdated
Show resolved
Hide resolved
| // NOTE: tokio semaphore is fair, permits are given out in the order requested | ||
| semaphore: Arc<Semaphore>, | ||
| mode: ConcurrencyMode, | ||
| tb_metrics: Arc<TokenBucketMetrics>, |
There was a problem hiding this comment.
I'm kind of wondering whether token bucket metrics provide value at this point in time. 🤔
There was a problem hiding this comment.
I am also not sure, but will probably leave them in place until I can actually run some benchmarks and test all of this on some real use cases. Can remove if we find it not necessary after that testing.
Remove permit acquisition/release tracking and simplify inflight request monitoring with consistent counter types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.