Skip to content

Fix ubuntu-18-x64 docker #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Fix ubuntu-18-x64 docker #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2293f1d
apt-get clean clearing cache may have been breaking ability to find s…
sbSteveK Sep 15, 2025
ea49993
point link to lines in a branch so they don't move around
sbSteveK Sep 15, 2025
d8c116f
grammer
sbSteveK Sep 15, 2025
7f87aca
point to python instead of python3 and insure python3 software proper…
sbSteveK Sep 15, 2025
4aff475
use sed to explicitly set to python3.6
sbSteveK Sep 15, 2025
1e5192b
python 3.10
sbSteveK Sep 15, 2025
1c22b1d
python 3.10 for application, python 3.6 for system tools
sbSteveK Sep 15, 2025
7ff78ec
keep system symlink intact
sbSteveK Sep 15, 2025
23c63b8
add logging to track what's happening
sbSteveK Sep 15, 2025
731e3f7
remove log and add python3-apt
sbSteveK Sep 15, 2025
1698345
add software-properties-common again
sbSteveK Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions .github/docker-images/ubuntu-18-x64/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ RUN apt-get update \
libxml2-dev \
libxmlsec1-dev \
libffi-dev \
liblzma-dev \
&& apt-get clean
software-properties-common \
liblzma-dev

# Build Python 3.10 from source
RUN cd /tmp \
Expand All @@ -43,16 +43,15 @@ RUN cd /tmp \
&& make altinstall \
&& cd / \
&& rm -rf /tmp/Python-3.10.12* \
&& ln -sf /usr/local/bin/python3.10 /usr/bin/python3 \
&& ln -sf /usr/local/bin/python3.10 /usr/local/bin/python \
&& /usr/local/bin/python3.10 --version

# Install Go from default Ubuntu repository
# Install Go and ensure system Python tools work
RUN apt-get update \
&& apt-get -y install \
software-properties-common \
golang-go \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*
python3-software-properties \
python3-apt \
golang-go

###############################################################################
# Python/AWS CLI
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ debugging experience:
* --build-dir=/path/to/other/git/repo - will jump to this directory before starting execution, helpful for debugging another project's
configuration and build scripts

When debugging builder from downstream CI (AWS common runtime repos), to use a branch of builder, you will need to change `BUILDER_VERSION` to the branch name of aws-crt-builder, and the `BUILDER_SOURCE` to be `channels` from `ci.yml`. Eg: for `aws-crt-java`, make those change to the [here](https://github.com/awslabs/aws-crt-java/blob/main/.github/workflows/ci.yml#L10-L11).
When debugging builder from downstream CI (AWS common runtime repos), to use a branch of builder, you will need to change `BUILDER_VERSION` to the branch name of aws-crt-builder, and the `BUILDER_SOURCE` to be `channels` from `ci.yml`. Eg: for `aws-crt-java`, make those changes [here](https://github.com/awslabs/aws-crt-java/blob/eb3813e4da89709fe71611fd4fdf59a5eef40336/.github/workflows/ci.yml#L10-L11).

### Docker Images
Each docker image has a script which will fetch the builder app baked into it, and will then call the builder with the arguments provided.
Expand Down