Skip to content

Add method existence check for getSelectedCandidatePair #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add method existence check for getSelectedCandidatePair #633

wants to merge 2 commits into from
+34 −1

Conversation

@YPandas
Copy link
Contributor

@YPandas YPandas commented Oct 24, 2025 •
edited
Loading

Issue:

  • Firefox doesn't implement the getSelectedCandidatePair() method, causing runtime errors when the application attempts to call this method.

Description of changes:

  • Added method existence check before calling it.
  • Add fallback method to log selected ICE candidate pairs when getSelectedCandidatePair() is not supported

BEFORE:
image

AFTER:
image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@YPandas YPandas changed the base branch from master to develop October 24, 2025 21:23
@YPandas YPandas closed this Oct 24, 2025
@YPandas YPandas force-pushed the firefox-method-issue branch from 6e5b906 to 93cc3e2 Compare October 24, 2025 21:27
@YPandas YPandas reopened this Oct 24, 2025
unicornss
unicornss previously approved these changes Oct 24, 2025
View reviewed changes
sirknightj
sirknightj previously approved these changes Oct 25, 2025
View reviewed changes
@sirknightj sirknightj changed the base branch from release-v2.4.4 to develop October 31, 2025 05:59
@sirknightj sirknightj dismissed stale reviews from unicornss and themself October 31, 2025 05:59

The base branch was changed.

@sirknightj sirknightj added Samples Questions related to Samples 2.4.5 labels Oct 31, 2025
@sirknightj sirknightj requested a review from unicornss November 1, 2025 21:17
stefankiesz
stefankiesz approved these changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@stefankiesz stefankiesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any alternative ways we could still log the selected candidate information for when that method does not exist?

@YPandas YPandas force-pushed the firefox-method-issue branch from eaff2aa to d6ef207 Compare November 3, 2025 21:36
@YPandas YPandas requested a review from stefankiesz November 4, 2025 19:13
@YPandas YPandas force-pushed the firefox-method-issue branch from 91f7309 to 4eb035b Compare November 4, 2025 20:10
@YPandas YPandas requested a review from sirknightj November 4, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sirknightj sirknightj sirknightj approved these changes

@unicornss unicornss Awaiting requested review from unicornss

@stefankiesz stefankiesz Awaiting requested review from stefankiesz

Assignees

No one assigned

Labels

2.4.5 compatibility Samples Questions related to Samples

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@YPandas @sirknightj @unicornss @stefankiesz