Skip to content

Making SdpMid ICE candidate property optional #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2025
Merged

Making SdpMid ICE candidate property optional #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions Swift/KVSiOSApp/SignalingClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,15 +136,21 @@ extension SignalingClient: WebSocketDelegate {
debugPrint("SDP answer received from signaling \(sdp)")
} else if messageType == "ICE_CANDIDATE" {
guard let iceCandidate = jsonObject["candidate"] as? String else {
print("Dropping \(jsonObject), due to missing 'candidate' property")
return
}
guard let sdpMid = jsonObject["sdpMid"] as? String else {
let sdpMid = jsonObject["sdpMid"] as? String
let sdpMLineIndex = jsonObject["sdpMLineIndex"] as? Int32

guard sdpMid != nil || sdpMLineIndex != nil else {
print("Dropping \(jsonObject), both sdpMid and sdpMLineIndex missing (at least one must be present)")
return
}
guard let sdpMLineIndex = jsonObject["sdpMLineIndex"] as? Int32 else {
return
}
let rtcIceCandidate: RTCIceCandidate = RTCIceCandidate(sdp: iceCandidate, sdpMLineIndex: sdpMLineIndex, sdpMid: sdpMid)
let rtcIceCandidate: RTCIceCandidate = RTCIceCandidate(
sdp: iceCandidate,
sdpMLineIndex: sdpMLineIndex ?? 0,
sdpMid: sdpMid
)
delegate?.signalClient(self, senderClientId: senderClientId!, didReceiveCandidate: rtcIceCandidate)
debugPrint("ICE candidate received from signaling \(iceCandidate)")
}
Expand Down