Skip to content

WIP: Further features and improvements for ESP Port #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: beta-reference-esp-port
Choose a base branch
from
Draft

WIP: Further features and improvements for ESP Port #2174

wants to merge 8 commits into from

Conversation

@vikramdattu
Copy link
Contributor

@vikramdattu vikramdattu commented Oct 14, 2025 •
edited
Loading

  • Fix network coprocessor for incorrect length of wifi_connected event
  • esp_hosted: fixes including wifi_started event miss
  • bugfix(media_stream): Fixed frame memory leak in video_capture
  • webrtc_split: Added deep-sleep and wake-up logic
  • data_channel: Added config in app_webrtc_config_t
  • Dependency cleanup from app_webrtc and examples
  • Remove requirement for ets_sys_define patch on esp-idf

mantriyogesh and others added 6 commits October 10, 2025 16:02
@mantriyogesh @vikramdattu
Fix network coprocessor for incorrect length of wifi_connected event
c4b3684
@vikramdattu
esp_hosted: fixes including wifi_started event miss
ba2ded0 
 - Check if netif is up while connected and up it if not
 - Fix wrong Wi-Fi state error: Do not err for connect request while already connecting
@vikramdattu
bugfix(media_stream): Fixed frame memory leak in video_capture
f3d96c4
@vikramdattu
webrtc_split: Added deep-sleep and wake-up logic
8ae5009 
How to test:
 - Put ESP32-P4 into deep sleep
 - Start streaming request from the viewer
 - ESP32-P4 will wake-up and further webrtc peer_connection will continue

How it works:
 - ESP32-C6 checks the message type
 - It wakes-up the P4 if there is an offer and queues all the messages till P4 is ready
 - It then sends a WAKEUP query message to confirm is P4 is ready to receive messages
 - Once confirm, it starts flushing the buffered messages
@vikramdattu
data_channel: Added config in app_webrtc_config_t
7ce47d5 
 - The existing API can still be used to override/set per peer_client callbacks: app_webrtc_set_data_channel_callbacks
@vikramdattu
Dependency cleanup from app_webrtc and examples
72473b3 
 - Removed not-used-anymore dependencies from app_webrtc component
 - When DTLS_SRTP not enabled, kept a macro in common.h to keep build system happy
   - The macro is used in `Crypto.h` and gets includes from Includes.h
 - signaling_only:
   - Disabled unused options and enabled mbedtls asymmetric buf option
   - tidy-up code and fix log formats
   - Make sure it builds for ESP32-P4 as well
@vikramdattu vikramdattu marked this pull request as draft October 14, 2025 13:44
@vikramdattu
Control KVS logging from single place
b597368 
 - Made app_webrtc_set_log_level effective and covered 0-8 level ranges
 - By default set this logging to info and can be modified with above API
 - Removed the layered APIs from WebRTCLogging.c

 - kvs_webrtc.h cleanup: Removed not-existant-anymore exposed APIs
@vikramdattu
Remove requirement for ets_sys_define patch on esp-idf
a0b637e 
 - Explicitly include ets_sys.h
 - Check for if enum is defined and undef before our own STATUS define to uint32_t
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vikramdattu @mantriyogesh