Skip to content

Conversation

@stefankiesz
Copy link
Contributor

@stefankiesz stefankiesz commented Mar 5, 2025

What was changed?

  • The TURN_CONNECTION_DATA_TRANSFER_MODE parameter passed into the createTurnConnection call in iceAgentInitRelayCandidate.
  • The name of one of the members of the TURN_CONNECTION_DATA_TRANSFER_MODE enum.

Why was it changed?

  • The passed parameter was changed because not only is it not used, the enum value that parameter is to set gets hardcoded in the same function to be a different enum value from the one passed in making it very confusing.
  • The enum member name had a typo.

How was it changed?

  • The passed parameter was changed to NULL.
  • The typo was corrected.

What testing was done for the changes?

  • Allowing for the CI tests to pass.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant