Skip to content

support ice-lite #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

support ice-lite #1754

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e481c2d
support ice-lite
zhuker Jul 17, 2023
5dc1cec
clang format
zhuker Jul 17, 2023
39d4e01
Merge branch 'develop' into ice-lite-2
zhuker Aug 1, 2023
a349ea7
Merge branch 'develop-pre-1.11.0' into ice-lite-2
zhuker May 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/source/PeerConnection/PeerConnection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1300,6 +1300,7 @@ STATUS setRemoteDescription(PRtcPeerConnection pPeerConnection, PRtcSessionDescr
ENTERS();
STATUS retStatus = STATUS_SUCCESS;
PCHAR remoteIceUfrag = NULL, remoteIcePwd = NULL;
BOOL controlling = FALSE;
UINT32 i, j;
PSessionDescription pSessionDescription;

Expand All @@ -1315,6 +1316,7 @@ STATUS setRemoteDescription(PRtcPeerConnection pPeerConnection, PRtcSessionDescr
NULLABLE_SET_VALUE(pKvsPeerConnection->canTrickleIce, FALSE);

CHK_STATUS(deserializeSessionDescription(pSessionDescription, pSessionDescriptionInit->sdp));
controlling = pKvsPeerConnection->isOffer;

for (i = 0; i < pSessionDescription->sessionAttributesCount; i++) {
if (STRCMP(pSessionDescription->sdpAttributes[i].attributeName, "fingerprint") == 0) {
Expand All @@ -1328,6 +1330,9 @@ STATUS setRemoteDescription(PRtcPeerConnection pPeerConnection, PRtcSessionDescr
} else if (STRCMP(pSessionDescription->sdpAttributes[i].attributeName, "ice-options") == 0 &&
STRSTR(pSessionDescription->sdpAttributes[i].attributeValue, "trickle") != NULL) {
NULLABLE_SET_VALUE(pKvsPeerConnection->canTrickleIce, TRUE);
} else if (STRCMP(pSessionDescription->sdpAttributes[i].attributeName, "ice-lite") == 0) {
// if remote description says "ice-lite" we are always the ice controlling side
controlling = TRUE;
}
}

Expand Down Expand Up @@ -1383,8 +1388,7 @@ STATUS setRemoteDescription(PRtcPeerConnection pPeerConnection, PRtcSessionDescr
STRNCPY(pKvsPeerConnection->remoteIcePwd, remoteIcePwd, MAX_ICE_PWD_LEN);

// This starts the state machine timer callback that transitions states periodically
CHK_STATUS(iceAgentStartAgent(pKvsPeerConnection->pIceAgent, pKvsPeerConnection->remoteIceUfrag, pKvsPeerConnection->remoteIcePwd,
pKvsPeerConnection->isOffer));
CHK_STATUS(iceAgentStartAgent(pKvsPeerConnection->pIceAgent, pKvsPeerConnection->remoteIceUfrag, pKvsPeerConnection->remoteIcePwd, controlling));

if (!pKvsPeerConnection->isOffer) {
CHK_STATUS(setPayloadTypesFromOffer(pKvsPeerConnection->pCodecTable, pKvsPeerConnection->pRtxTable, pSessionDescription));
Expand Down