Skip to content

Conversation

@sirknightj
Copy link
Contributor

Issue #, if available:

  • N/A

What was changed?

  • Added integration tests: StreamCallbacksErrorHandlingIntegTest to validate SDK error handling when user-implemented stream callbacks throw exceptions and errors

Why was it changed?

  • To ensure the Kinesis Video Streams Producer SDK gracefully handles application errors in user callback implementations without breaking the streaming pipeline.
  • This addresses a critical reliability requirement where SDK robustness should not depend on perfect user code.

How was it changed?

  • Created fault-injection integration test that intentionally throws RuntimeException in fragmentAckReceived callback. Streams to a Kinesis Video Stream using the ImageFileMediaSource similar to DemoAppMain.
  • Test verifies SDK continues normal operation and receives PERSISTED fragment acknowledgments despite callback errors

What testing was done for the changes?

  • Ran the tests locally
  • Ran DemoAppMain locally

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.87%. Comparing base (538041c) to head (27313f1).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #248      +/-   ##
=============================================
+ Coverage      49.83%   49.87%   +0.04%     
- Complexity       585      587       +2     
=============================================
  Files            106      106              
  Lines           4154     4154              
  Branches         268      268              
=============================================
+ Hits            2070     2072       +2     
  Misses          1936     1936              
+ Partials         148      146       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sirknightj sirknightj force-pushed the checking-callback-error-handling branch 2 times, most recently from 2c8a220 to 040f793 Compare August 12, 2025 23:02
@sirknightj sirknightj requested a review from Ahhorse1 August 18, 2025 02:31
@sirknightj
Copy link
Contributor Author

Rebase to latest develop branch

@sirknightj sirknightj force-pushed the checking-callback-error-handling branch from 8c5fab1 to 27313f1 Compare September 2, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants