Jni clientinfo #211
Draft
Jni clientinfo #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add logs * Added classes, successfully built and ran * Revert "Add logs" * Remove getKvsRetryStrategyCallbacks * Add getters for all new members, fix typos, make AutomaticStreamingFlags class * Fix KvsRetryStrategyType * Update constructor param names * Return long members in getters rather than 0 for unsupported members * Update
unicornss
approved these changes
Apr 11, 2025
src/main/java/com/amazonaws/kinesisvideo/producer/AutomaticStreamingFlags.java
Show resolved
Hide resolved
| final long serviceCallCompletionTimeout, final int logLevel, | ||
| final boolean logMetric, final AutomaticStreamingFlags flag) { | ||
| mVersion = CLIENT_INFO_CURRENT_VERSION; | ||
| mCreateClientTimeout = createClientTimeout; |
There was a problem hiding this comment.
should it be consistent with the native with suffix as ms? or seconds?
src/main/java/com/amazonaws/kinesisvideo/producer/KvsRetryStrategyType.java
Show resolved
Hide resolved
unicornss
approved these changes
Apr 15, 2025
unicornss
reviewed
Apr 16, 2025
| * <p> | ||
| * A generic retry strategy | ||
| * | ||
| * @see <a href="https://github.com/awslabs/amazon-kinesis-video-streams-pic/blob/master/src/utils/include/com/amazonaws/kinesis/video/utils/Include.h">PIC</a> |
sirknightj
commented
Apr 17, 2025
| } | ||
|
|
||
| @Override | ||
| public void getCurrentRetryAttemptNumberFn(KvsRetryStrategy kvsRetryStrategy, int retryCount) throws ProducerException { |
There was a problem hiding this comment.
Doesn't seem right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
What was changed?
Why was it changed?
How was it changed?
What testing was done for the changes?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.