-
Notifications
You must be signed in to change notification settings - Fork 79
Old develop commits #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Old develop commits #210
Conversation
* add test for store pressure policy check * set value for storePressurePolicy * update constructor * make storePressurePolicy final * remove additional assignment
Co-authored-by: Nicholas Cellino <[email protected]>
Co-authored-by: Nicholas Cellino <[email protected]>
* add checks and throw exceptions * fix ci * comments * use log4j2
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #210 +/- ##
=============================================
+ Coverage 40.13% 41.27% +1.13%
- Complexity 407 426 +19
=============================================
Files 103 103
Lines 3797 3804 +7
Branches 237 242 +5
=============================================
+ Hits 1524 1570 +46
+ Misses 2154 2120 -34
+ Partials 119 114 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest updating the comments to indicate the context for test coverage and shorter runs
|
@unicornss, Updated the PR description |
Issue #, if available:
What was changed?
Why was it changed?
How was it changed?
What testing was done for the changes?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.