Skip to content

review ready - Update the device-managemet-agent as per the Guidelines - requested by Eashan #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

review ready - Update the device-managemet-agent as per the Guidelines - requested by Eashan #508

wants to merge 13 commits into from

Conversation

vgodwinamz
Copy link
Contributor

@vgodwinamz vgodwinamz commented Oct 16, 2025 •
edited
Loading

review ready - Amazon Bedrock AgentCore Samples Pull Request

Important

  1. We strictly follow a issue-first approach, please first open an issue relating to this Pull Request.
  2. Once this Pull Request is ready for review please attach review ready label to it. Only PRs with review ready will be reviewed.

Issue number: #509

Concise description of the PR

Updated to device-management-agent use case based on guidelines , because  to avoid being included in Sev 2 security tickets.

User experience

Just updated based on the requested guidelines

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • [ X] I have reviewed the contributing guidelines
  • [X ] Add your name to CONTRIBUTORS.md
  • [ X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Are you uploading a dataset?
  • [ X] Have you documented Introduction, Architecture Diagram, Prerequisites, Usage, Sample Prompts, and Clean Up steps in your example README?
  • [ X] I agree to resolve any issues created for this example in the future.
  • [ X] I have performed a self-review of this change
  • [X ] Changes have been tested
  • [ X] Changes are documented

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@github-actions github-actions bot added 02-use-cases 02-use-cases device-management-agent 02-use-cases/device-management-agent labels Oct 16, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2025 •
edited
Loading

Latest scan for commit: 7316890 | Updated: 2025-10-16 20:39:07 UTC

Security Scan Results

Scan Metadata

  • Project: ASH
  • Scan executed: 2025-10-16T20:38:11+00:00
  • ASH version: 3.0.0

Summary

Scanner Results

The table below shows findings by scanner, with status based on severity thresholds and dependencies:

Column Explanations:

Severity Levels (S/C/H/M/L/I):

  • Suppressed (S): Security findings that have been explicitly suppressed/ignored and don't affect the scanner's pass/fail status
  • Critical (C): The most severe security vulnerabilities requiring immediate remediation (e.g., SQL injection, remote code execution)
  • High (H): Serious security vulnerabilities that should be addressed promptly (e.g., authentication bypasses, privilege escalation)
  • Medium (M): Moderate security risks that should be addressed in normal development cycles (e.g., weak encryption, input validation issues)
  • Low (L): Minor security concerns with limited impact (e.g., information disclosure, weak recommendations)
  • Info (I): Informational findings for awareness with minimal security risk (e.g., code quality suggestions, best practice recommendations)

Other Columns:

  • Time: Duration taken by each scanner to complete its analysis
  • Action: Total number of actionable findings at or above the configured severity threshold that require attention

Scanner Results:

  • PASSED: Scanner found no security issues at or above the configured severity threshold - code is clean for this scanner
  • FAILED: Scanner found security vulnerabilities at or above the threshold that require attention and remediation
  • MISSING: Scanner could not run because required dependencies/tools are not installed or available
  • SKIPPED: Scanner was intentionally disabled or excluded from this scan
  • ERROR: Scanner encountered an execution error and could not complete successfully

Severity Thresholds (Thresh Column):

  • CRITICAL: Only Critical severity findings cause scanner to fail
  • HIGH: High and Critical severity findings cause scanner to fail
  • MEDIUM (MED): Medium, High, and Critical severity findings cause scanner to fail
  • LOW: Low, Medium, High, and Critical severity findings cause scanner to fail
  • ALL: Any finding of any severity level causes scanner to fail

Threshold Source: Values in parentheses indicate where the threshold is configured:

  • (g) = global: Set in the global_settings section of ASH configuration
  • (c) = config: Set in the individual scanner configuration section
  • (s) = scanner: Default threshold built into the scanner itself

Statistics calculation:

  • All statistics are calculated from the final aggregated SARIF report
  • Suppressed findings are counted separately and do not contribute to actionable findings
  • Scanner status is determined by comparing actionable findings to the threshold
Scanner S C H M L I Time Action Result Thresh
bandit 0 0 0 0 94 0 1.8s 0 PASSED MED (g)
cdk-nag 0 0 0 0 0 0 30.8s 0 PASSED MED (g)
cfn-nag 0 0 0 0 0 0 8ms 0 PASSED MED (g)
checkov 0 0 0 0 0 0 5.3s 0 PASSED MED (g)
detect-secre… 0 0 0 0 0 0 1.5s 0 PASSED MED (g)
grype 0 6 0 12 0 0 31.5s 18 FAILED MED (g)
npm-audit 0 0 0 0 0 0 219ms 0 PASSED MED (g)
opengrep 0 0 0 0 0 0 <1ms 0 SKIPPED MED (g)
semgrep 0 0 0 0 0 0 16.9s 0 PASSED MED (g)
syft 0 0 0 0 0 0 2.1s 0 PASSED MED (g)

Detailed Findings

Show 18 actionable findings

Finding 1: GHSA-2jv5-9r88-3w3p-python-multipart

  • Severity: HIGH
  • Scanner: grype
  • Rule ID: GHSA-2jv5-9r88-3w3p-python-multipart
  • Location: 02-use-cases/device-management-agent/requirements.txt:1

Description:
A high vulnerability in python package: python-multipart, version 0.0.6 was found at: /02-use-cases/device-management-agent/requirements.txt

Finding 2: GHSA-2jv5-9r88-3w3p-python-multipart

  • Severity: HIGH
  • Scanner: grype
  • Rule ID: GHSA-2jv5-9r88-3w3p-python-multipart
  • Location: 02-use-cases/device-management-agent/frontend/requirements.txt:1

Description:
A high vulnerability in python package: python-multipart, version 0.0.6 was found at: /02-use-cases/device-management-agent/frontend/requirements.txt

Finding 3: GHSA-6c5p-j8vq-pqhj-python-jose

  • Severity: HIGH
  • Scanner: grype
  • Rule ID: GHSA-6c5p-j8vq-pqhj-python-jose
  • Location: 02-use-cases/device-management-agent/frontend/requirements.txt:1

Description:
A critical vulnerability in python package: python-jose, version 3.3.0 was found at: /02-use-cases/device-management-agent/frontend/requirements.txt

Finding 4: GHSA-6c5p-j8vq-pqhj-python-jose

  • Severity: HIGH
  • Scanner: grype
  • Rule ID: GHSA-6c5p-j8vq-pqhj-python-jose
  • Location: 02-use-cases/device-management-agent/requirements.txt:1

Description:
A critical vulnerability in python package: python-jose, version 3.3.0 was found at: /02-use-cases/device-management-agent/requirements.txt

Finding 5: GHSA-h75v-3vvj-5mfj-jinja2

  • Severity: MEDIUM
  • Scanner: grype
  • Rule ID: GHSA-h75v-3vvj-5mfj-jinja2
  • Location: 02-use-cases/device-management-agent/frontend/requirements.txt:1

Description:
A medium vulnerability in python package: jinja2, version 3.1.2 was found at: /02-use-cases/device-management-agent/frontend/requirements.txt

Finding 6: GHSA-h75v-3vvj-5mfj-jinja2

  • Severity: MEDIUM
  • Scanner: grype
  • Rule ID: GHSA-h75v-3vvj-5mfj-jinja2
  • Location: 02-use-cases/device-management-agent/requirements.txt:1

Description:
A medium vulnerability in python package: jinja2, version 3.1.2 was found at: /02-use-cases/device-management-agent/requirements.txt

Finding 7: GHSA-59g5-xgcq-4qw3-python-multipart

  • Severity: HIGH
  • Scanner: grype
  • Rule ID: GHSA-59g5-xgcq-4qw3-python-multipart
  • Location: 02-use-cases/device-management-agent/frontend/requirements.txt:1

Description:
A high vulnerability in python package: python-multipart, version 0.0.6 was found at: /02-use-cases/device-management-agent/frontend/requirements.txt

Finding 8: GHSA-59g5-xgcq-4qw3-python-multipart

  • Severity: HIGH
  • Scanner: grype
  • Rule ID: GHSA-59g5-xgcq-4qw3-python-multipart
  • Location: 02-use-cases/device-management-agent/requirements.txt:1

Description:
A high vulnerability in python package: python-multipart, version 0.0.6 was found at: /02-use-cases/device-management-agent/requirements.txt

Finding 9: GHSA-cjwg-qfpm-7377-python-jose

  • Severity: MEDIUM
  • Scanner: grype
  • Rule ID: GHSA-cjwg-qfpm-7377-python-jose
  • Location: 02-use-cases/device-management-agent/frontend/requirements.txt:1

Description:
A medium vulnerability in python package: python-jose, version 3.3.0 was found at: /02-use-cases/device-management-agent/frontend/requirements.txt

Finding 10: GHSA-cjwg-qfpm-7377-python-jose

  • Severity: MEDIUM
  • Scanner: grype
  • Rule ID: GHSA-cjwg-qfpm-7377-python-jose
  • Location: 02-use-cases/device-management-agent/requirements.txt:1

Description:
A medium vulnerability in python package: python-jose, version 3.3.0 was found at: /02-use-cases/device-management-agent/requirements.txt

Finding 11: GHSA-q2x7-8rv6-6q7h-jinja2

  • Severity: MEDIUM
  • Scanner: grype
  • Rule ID: GHSA-q2x7-8rv6-6q7h-jinja2
  • Location: 02-use-cases/device-management-agent/requirements.txt:1

Description:
A medium vulnerability in python package: jinja2, version 3.1.2 was found at: /02-use-cases/device-management-agent/requirements.txt

Finding 12: GHSA-q2x7-8rv6-6q7h-jinja2

  • Severity: MEDIUM
  • Scanner: grype
  • Rule ID: GHSA-q2x7-8rv6-6q7h-jinja2
  • Location: 02-use-cases/device-management-agent/frontend/requirements.txt:1

Description:
A medium vulnerability in python package: jinja2, version 3.1.2 was found at: /02-use-cases/device-management-agent/frontend/requirements.txt

Finding 13: GHSA-cpwx-vrp4-4pq7-jinja2

  • Severity: MEDIUM
  • Scanner: grype
  • Rule ID: GHSA-cpwx-vrp4-4pq7-jinja2
  • Location: 02-use-cases/device-management-agent/frontend/requirements.txt:1

Description:
A medium vulnerability in python package: jinja2, version 3.1.2 was found at: /02-use-cases/device-management-agent/frontend/requirements.txt

Finding 14: GHSA-cpwx-vrp4-4pq7-jinja2

  • Severity: MEDIUM
  • Scanner: grype
  • Rule ID: GHSA-cpwx-vrp4-4pq7-jinja2
  • Location: 02-use-cases/device-management-agent/requirements.txt:1

Description:
A medium vulnerability in python package: jinja2, version 3.1.2 was found at: /02-use-cases/device-management-agent/requirements.txt

Finding 15: GHSA-h5c8-rqwp-cp95-jinja2

  • Severity: MEDIUM
  • Scanner: grype
  • Rule ID: GHSA-h5c8-rqwp-cp95-jinja2
  • Location: 02-use-cases/device-management-agent/requirements.txt:1

Description:
A medium vulnerability in python package: jinja2, version 3.1.2 was found at: /02-use-cases/device-management-agent/requirements.txt

Finding 16: GHSA-h5c8-rqwp-cp95-jinja2

  • Severity: MEDIUM
  • Scanner: grype
  • Rule ID: GHSA-h5c8-rqwp-cp95-jinja2
  • Location: 02-use-cases/device-management-agent/frontend/requirements.txt:1

Description:
A medium vulnerability in python package: jinja2, version 3.1.2 was found at: /02-use-cases/device-management-agent/frontend/requirements.txt

Finding 17: GHSA-gmj6-6f8f-6699-jinja2

  • Severity: MEDIUM
  • Scanner: grype
  • Rule ID: GHSA-gmj6-6f8f-6699-jinja2
  • Location: 02-use-cases/device-management-agent/requirements.txt:1

Description:
A medium vulnerability in python package: jinja2, version 3.1.2 was found at: /02-use-cases/device-management-agent/requirements.txt

Finding 18: GHSA-gmj6-6f8f-6699-jinja2

  • Severity: MEDIUM
  • Scanner: grype
  • Rule ID: GHSA-gmj6-6f8f-6699-jinja2
  • Location: 02-use-cases/device-management-agent/frontend/requirements.txt:1

Description:
A medium vulnerability in python package: jinja2, version 3.1.2 was found at: /02-use-cases/device-management-agent/frontend/requirements.txt

Report generated by Automated Security Helper (ASH) at 2025-10-16T20:38:05+00:00

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 16, 2025
View reviewed changes
@vgodwinamz
Copy link
Contributor Author

here is the approval from guaridans review - https://t.corp.amazon.com/V1960132803/overview

@vgodwinamz vgodwinamz changed the title Update the device-managemet-agent as per the Guidelines - requested by Eashan review ready - Update the device-managemet-agent as per the Guidelines - requested by Eashan Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

02-use-cases 02-use-cases device-management-agent 02-use-cases/device-management-agent

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vgodwinamz