Skip to content

Conversation

@sasikiran-malladi
Copy link

Enable Transaction Search, CloudWatch Logs Data Protection policies and Bedrock Guardrails

Amazon Bedrock AgentCore Samples Pull Request

Important

  1. We strictly follow a issue-first approach, please first open an issue relating to this Pull Request.
  2. Once this Pull Request is ready for review please attach review ready label to it. Only PRs with review ready will be reviewed.

Issue number: #485

Concise description of the PR

Enable Transaction Search, CloudWatch Logs Data Protection policies and Bedrock Guardrails

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • [ x] I have reviewed the contributing guidelines
  • [ x] Add your name to CONTRIBUTORS.md
  • [x ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [x ] Are you uploading a dataset?
  • [x ] Have you documented Introduction, Architecture Diagram, Prerequisites, Usage, Sample Prompts, and Clean Up steps in your example README?
  • [ x] I agree to resolve any issues created for this example in the future.
  • [x ] I have performed a self-review of this change
  • [ x] Changes have been tested
  • [x ] Changes are documented

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

…h Logs Data Protection policies and Bedrock Guardrails
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added 01-tutorials 01-tutorials 06-AgentCore-observability 01-tutorials/06-AgentCore-observability labels Oct 14, 2025
@github-actions
Copy link

Latest scan for commit: 2672ee9 | Updated: 2025-10-14 16:08:48 UTC

Security Scan Results

Scan Metadata

  • Project: ASH
  • Scan executed: 2025-10-14T16:02:23+00:00
  • ASH version: 3.0.0

Summary

Scanner Results

The table below shows findings by scanner, with status based on severity thresholds and dependencies:

Column Explanations:

Severity Levels (S/C/H/M/L/I):

  • Suppressed (S): Security findings that have been explicitly suppressed/ignored and don't affect the scanner's pass/fail status
  • Critical (C): The most severe security vulnerabilities requiring immediate remediation (e.g., SQL injection, remote code execution)
  • High (H): Serious security vulnerabilities that should be addressed promptly (e.g., authentication bypasses, privilege escalation)
  • Medium (M): Moderate security risks that should be addressed in normal development cycles (e.g., weak encryption, input validation issues)
  • Low (L): Minor security concerns with limited impact (e.g., information disclosure, weak recommendations)
  • Info (I): Informational findings for awareness with minimal security risk (e.g., code quality suggestions, best practice recommendations)

Other Columns:

  • Time: Duration taken by each scanner to complete its analysis
  • Action: Total number of actionable findings at or above the configured severity threshold that require attention

Scanner Results:

  • PASSED: Scanner found no security issues at or above the configured severity threshold - code is clean for this scanner
  • FAILED: Scanner found security vulnerabilities at or above the threshold that require attention and remediation
  • MISSING: Scanner could not run because required dependencies/tools are not installed or available
  • SKIPPED: Scanner was intentionally disabled or excluded from this scan
  • ERROR: Scanner encountered an execution error and could not complete successfully

Severity Thresholds (Thresh Column):

  • CRITICAL: Only Critical severity findings cause scanner to fail
  • HIGH: High and Critical severity findings cause scanner to fail
  • MEDIUM (MED): Medium, High, and Critical severity findings cause scanner to fail
  • LOW: Low, Medium, High, and Critical severity findings cause scanner to fail
  • ALL: Any finding of any severity level causes scanner to fail

Threshold Source: Values in parentheses indicate where the threshold is configured:

  • (g) = global: Set in the global_settings section of ASH configuration
  • (c) = config: Set in the individual scanner configuration section
  • (s) = scanner: Default threshold built into the scanner itself

Statistics calculation:

  • All statistics are calculated from the final aggregated SARIF report
  • Suppressed findings are counted separately and do not contribute to actionable findings
  • Scanner status is determined by comparing actionable findings to the threshold
Scanner S C H M L I Time Action Result Thresh
bandit 0 0 0 0 0 0 651ms 0 PASSED MED (g)
cdk-nag 0 0 0 0 0 0 27.7s 0 PASSED MED (g)
cfn-nag 0 0 0 0 0 0 1.2s 0 PASSED MED (g)
checkov 0 0 0 0 0 0 4.6s 0 PASSED MED (g)
detect-secrets 0 0 0 0 0 0 626ms 0 PASSED MED (g)
grype 0 0 0 0 0 0 29.1s 0 PASSED MED (g)
npm-audit 0 0 0 0 0 0 168ms 0 PASSED MED (g)
opengrep 0 0 0 0 0 0 <1ms 0 SKIPPED MED (g)
semgrep 0 0 0 0 0 0 12.9s 0 PASSED MED (g)
syft 0 0 0 0 0 0 1.9s 0 PASSED MED (g)

Copy link
Contributor

@mvangara10 mvangara10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move the 02-enable-transaction to root observability folder and please rename to 00-enable-transaction-search-template

Update the read me that this is a pre requisite to enable TS on cloudwatch - and this is one of the way to do so.

Copy link
Contributor

@mvangara10 mvangara10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the agent to be hosted on AgentCore runtime so users don't have to configure the variables. Please add Readme's in each sub folder

EashanKaushik and others added 14 commits October 16, 2025 13:07
* vpc

* vpc

* mcp stack

* number productid

* test agent

* mcp

* mcp

* todo

* mcp

* otel mcp

* otel mcp

* automation

* agent vpc

* provider

* agent

* changes

* lifespan

* changes

* changes

* context var

* context var

* aurora client

* aurora client

* agent dockerfile

* agent logs

* dataplane api

* dataplane api

* dataplane api

* identity token

* identity token

* identity token

* simple

* simple

* simple

* mcp

* mcp tool

* mcp tool impl

* mcp tool imple

* mcp tool imple

* log error

* log error

* log error

* depend

* depend

* new docker

* mcp script

* aurora test

* lifespan

* lifespan

* all tools

* middleware remove

* middleware remove

* middleware remove

* iac

* readme

* readme changes

* readme completed

* frontend

* customer support optimize

* frontend

* frontend

* schema

* schema

* frontend

* docs

* gateway

* Update agent-server-stack.yaml

Signed-off-by: Eashan Kaushik <[email protected]>

* Update mcp-server-stack.yaml

Signed-off-by: Eashan Kaushik <[email protected]>

* Enabling logs by default on runtime and gateway

* removing unused import

* reformatting files

---------

Signed-off-by: Eashan Kaushik <[email protected]>
Co-authored-by: Maira Ladeira Tanke <[email protected]>
* Add CloudFormation samples for MCP Server on AgentCore Runtime

- Created 04-cfn-samples/ directory with production-ready CloudFormation templates
- Added mcp-server-agentcore-runtime sample with:
  - Complete CloudFormation template (mcp-server-template.yaml)
  - Automated deployment scripts (deploy.sh, test.sh, cleanup.sh)
  - Authentication helper (get_token.py)
  - MCP client test script (test_mcp_server.py)
  - Comprehensive documentation (README.md, DETAILED_GUIDE.md)
- Features:
  - One-command deployment with automated Docker image building
  - JWT authentication via Cognito
  - ARM64 Docker images built via CodeBuild
  - Three sample MCP tools (add_numbers, multiply_numbers, greet_user)
  - Least-privilege IAM roles
  - Complete troubleshooting guide

* Add omrsamer to CONTRIBUTORS.md

* Add three additional CloudFormation samples

- Added basic-runtime: Simple agent without tools or memory
- Added multi-agent-runtime: Two-agent system with orchestrator and specialist
- Added weather-agent-runtime: Complete agent with browser, code interpreter, and memory
- Updated main README with all four samples and comprehensive documentation

* Add deployment and cleanup scripts for all CFN samples

- Added deploy.sh and cleanup.sh for basic-runtime
- Added deploy.sh and cleanup.sh for multi-agent-runtime
- Added deploy.sh and cleanup.sh for weather-agent-runtime
- All scripts are executable and follow the same pattern as mcp-server-agentcore-runtime
- Scripts include proper error handling and user-friendly output

* Add comprehensive README documentation for CFN samples with architecture diagrams

- Added detailed README.md files for basic-runtime, multi-agent-runtime, and weather-agent-runtime
- Included architecture PNG diagrams for basic-runtime and multi-agent-runtime
- Standardized testing sections across all READMEs (AWS CLI and Console only)
- Removed Python testing sections for consistency
- Added deployment, testing, troubleshooting, and cost estimate sections
- Updated CONTRIBUTORS.md with contributor name
- Updated main 04-cfn-samples README.md

* Add architecture diagram to mcp-server-agentcore-runtime README

- Added architecture.png with visual diagram
- Updated README to use local PNG instead of tutorial reference
- Added detailed architecture component descriptions

* Update get_token.py cosmetic changes

* Fix Python formatting to pass ruff linter

* Restructure infrastructure samples: rename to 04-infrastructure-as-code and organize CloudFormation templates

- Rename 04-cfn-samples to 04-infrastructure-as-code
- Create cloudformation subfolder for better organization
- Rename weather-agent-runtime to end-to-end-weather-agent
- Rename weather agent template.yaml to end-to-end-weather-agent.yaml
- Update all documentation and scripts to reflect new structure
- Update main README with new paths and folder structure
- All Python files pass ruff formatting checks

* Update CloudFormation examples to use us-west-2 region and remove production-ready language

- Changed all deploy.sh, cleanup.sh, and test.sh scripts from us-east-1 to us-west-2
- Updated all README files with CLI examples to use us-west-2
- Updated Python helper scripts (get_token.py, test_mcp_server.py) to use us-west-2 in examples
- Updated multi-agent-runtime template.yaml default region to us-west-2
- Removed 'production-ready' language from README files, replaced with 'complete'
- All 4 CloudFormation examples now consistently use us-west-2 region

* Resolve CONTRIBUTORS.md merge conflict - include all contributors from both branches

---------

Signed-off-by: Maira Ladeira Tanke <[email protected]>
Co-authored-by: Maira Ladeira Tanke <[email protected]>
* performance tuning

* fix

* fix
Changes to observability folder and adding crew AI samples.
* performance tuning

* fix

* fix

* fixing typo
* vpc

* vpc

* mcp stack

* number productid

* test agent

* mcp

* mcp

* todo

* mcp

* otel mcp

* otel mcp

* automation

* agent vpc

* provider

* agent

* changes

* lifespan

* changes

* changes

* context var

* context var

* aurora client

* aurora client

* agent dockerfile

* agent logs

* dataplane api

* dataplane api

* dataplane api

* identity token

* identity token

* identity token

* simple

* simple

* simple

* mcp

* mcp tool

* mcp tool impl

* mcp tool imple

* mcp tool imple

* log error

* log error

* log error

* depend

* depend

* new docker

* mcp script

* aurora test

* lifespan

* lifespan

* all tools

* middleware remove

* middleware remove

* middleware remove

* iac

* readme

* readme changes

* readme completed

* frontend

* customer support optimize

* frontend

* frontend

* schema

* schema

* frontend

* docs

* gateway

* Update agent-server-stack.yaml

Signed-off-by: Eashan Kaushik <[email protected]>

* Update mcp-server-stack.yaml

Signed-off-by: Eashan Kaushik <[email protected]>

* Enabling logs by default on runtime and gateway

* removing unused import

* reformatting files

* new prompts

---------

Signed-off-by: Eashan Kaushik <[email protected]>
Co-authored-by: Maira Ladeira Tanke <[email protected]>
…slabs#442)

* Add browser tool with Strands integration tutorial and update contributors

- Add new tutorial: 03-browser-with-Strands with Jupyter notebook and requirements
- Update CONTRIBUTORS.md with new contributor information
- Update .gitignore to exclude .kiro and .vscode directories

* Update browser tool tutorial with renamed notebook

- Rename notebook to 01_getting_started-agentcore-browser-tool-with-strands.ipynb
- Update .gitignore with additional exclusions

* Remove complex timeout handling from Strands browser tutorial

- Simplified Step 4 invoke function by removing signal-based timeout protection
- Added simple comment about implementing timeout handling for slow websites
- Removed complex timeout_handler and invoke_with_timeout functions
- Updated notebook with executed results showing successful Tesla stock analysis
- Maintained clean error handling while simplifying timeout approach
- All cells executed successfully with real MarketWatch financial data
* adding notebook for self managed strategy

* renamed folder name using-strands-self-managed-strategy

* renamed folder name using-strands-self-managed-strategy

* renamed folder name using-strands-self-managed-strategy

* removed vscode file

* renamed to culinary-assistant-self-managed-strategy
* Bump starter toolkit version, update nb reference

* Fix: update wording for agent test

---------

Signed-off-by: frank-aws <[email protected]>
…h Logs Data Protection policies and Bedrock Guardrails
@github-actions github-actions bot added 01-AgentCore-runtime 01-tutorials/01-AgentCore-runtime 02-AgentCore-gateway 01-tutorials/02-AgentCore-gateway 04-AgentCore-memory 01-tutorials/04-AgentCore-memory 05-AgentCore-tools 01-tutorials/05-AgentCore-tools 02-use-cases 02-use-cases labels Oct 16, 2025
@sunkavar
Copy link
Contributor

Closing this PR and opened a new one below
#512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

01-AgentCore-runtime 01-tutorials/01-AgentCore-runtime 01-tutorials 01-tutorials 02-AgentCore-gateway 01-tutorials/02-AgentCore-gateway 02-use-cases 02-use-cases 04-AgentCore-memory 01-tutorials/04-AgentCore-memory 05-AgentCore-tools 01-tutorials/05-AgentCore-tools 06-AgentCore-observability 01-tutorials/06-AgentCore-observability

Projects

None yet

Development

Successfully merging this pull request may close these issues.