Skip to content

Conversation

pyraenix
Copy link
Contributor

@pyraenix pyraenix commented Oct 6, 2025

Amazon Bedrock AgentCore Samples Pull Request

Important

  1. We strictly follow a issue-first approach, please first open an issue relating to this Pull Request.
  2. Once this Pull Request is ready for review please attach review ready label to it. Only PRs with review ready will be reviewed.

Issue number: #441

Concise description of the PR

Add comprehensive Strands Agent integration tutorial for AgentCore Browser Tool, including complete Jupyter notebook with MarketWatch financial analysis demo, automated setup scripts, and timeout handling, because developers need a working example of how to integrate Strands agents with Amazon Bedrock AgentCore browser functionality for web automation and financial data analysis.

User experience

Please share what the user experience looks like before and after this change

Before this change:
No tutorial or example showing how to integrate Strands agents with AgentCore browser tool

After this change:
Complete step-by-step tutorial with 7 sections covering installation to production usage
Working MarketWatch financial analysis example with stock data extraction
Automated setup script for easy environment configuration
Timeout protection and error handling
Interactive functions for custom website analysis

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have reviewed the contributing guidelines
  • Add your name to CONTRIBUTORS.md
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Are you uploading a dataset?
  • Have you documented Introduction, Architecture Diagram, Prerequisites, Usage, Sample Prompts, and Clean Up steps in your example README?
  • I agree to resolve any issues created for this example in the future.
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added 01-tutorials 01-tutorials 05-AgentCore-tools 01-tutorials/05-AgentCore-tools labels Oct 6, 2025
…utors

- Add new tutorial: 03-browser-with-Strands with Jupyter notebook and requirements
- Update CONTRIBUTORS.md with new contributor information
- Update .gitignore to exclude .kiro and .vscode directories
- Rename notebook to 01_getting_started-agentcore-browser-tool-with-strands.ipynb
- Update .gitignore with additional exclusions
Copy link
Contributor

@vedashreevinay vedashreevinay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please help me understand why the timeout protection is needed?

- Simplified Step 4 invoke function by removing signal-based timeout protection
- Added simple comment about implementing timeout handling for slow websites
- Removed complex timeout_handler and invoke_with_timeout functions
- Updated notebook with executed results showing successful Tesla stock analysis
- Maintained clean error handling while simplifying timeout approach
- All cells executed successfully with real MarketWatch financial data
Copy link

Latest scan for commit: 3616ae1 | Updated: 2025-10-15 19:16:04 UTC

Security Scan Results

Scan Metadata

  • Project: ASH
  • Scan executed: 2025-10-15T19:15:50+00:00
  • ASH version: 3.0.0

Summary

Scanner Results

The table below shows findings by scanner, with status based on severity thresholds and dependencies:

Column Explanations:

Severity Levels (S/C/H/M/L/I):

  • Suppressed (S): Security findings that have been explicitly suppressed/ignored and don't affect the scanner's pass/fail status
  • Critical (C): The most severe security vulnerabilities requiring immediate remediation (e.g., SQL injection, remote code execution)
  • High (H): Serious security vulnerabilities that should be addressed promptly (e.g., authentication bypasses, privilege escalation)
  • Medium (M): Moderate security risks that should be addressed in normal development cycles (e.g., weak encryption, input validation issues)
  • Low (L): Minor security concerns with limited impact (e.g., information disclosure, weak recommendations)
  • Info (I): Informational findings for awareness with minimal security risk (e.g., code quality suggestions, best practice recommendations)

Other Columns:

  • Time: Duration taken by each scanner to complete its analysis
  • Action: Total number of actionable findings at or above the configured severity threshold that require attention

Scanner Results:

  • PASSED: Scanner found no security issues at or above the configured severity threshold - code is clean for this scanner
  • FAILED: Scanner found security vulnerabilities at or above the threshold that require attention and remediation
  • MISSING: Scanner could not run because required dependencies/tools are not installed or available
  • SKIPPED: Scanner was intentionally disabled or excluded from this scan
  • ERROR: Scanner encountered an execution error and could not complete successfully

Severity Thresholds (Thresh Column):

  • CRITICAL: Only Critical severity findings cause scanner to fail
  • HIGH: High and Critical severity findings cause scanner to fail
  • MEDIUM (MED): Medium, High, and Critical severity findings cause scanner to fail
  • LOW: Low, Medium, High, and Critical severity findings cause scanner to fail
  • ALL: Any finding of any severity level causes scanner to fail

Threshold Source: Values in parentheses indicate where the threshold is configured:

  • (g) = global: Set in the global_settings section of ASH configuration
  • (c) = config: Set in the individual scanner configuration section
  • (s) = scanner: Default threshold built into the scanner itself

Statistics calculation:

  • All statistics are calculated from the final aggregated SARIF report
  • Suppressed findings are counted separately and do not contribute to actionable findings
  • Scanner status is determined by comparing actionable findings to the threshold
Scanner S C H M L I Time Action Result Thresh
bandit 0 0 0 0 0 0 634ms 0 PASSED MED (g)
cdk-nag 0 0 0 0 0 0 27.7s 0 PASSED MED (g)
cfn-nag 0 0 0 0 0 0 32ms 0 PASSED MED (g)
checkov 0 0 0 0 0 0 4.1s 0 PASSED MED (g)
detect-secrets 0 0 0 0 0 0 606ms 0 PASSED MED (g)
grype 0 0 0 0 0 0 30.4s 0 PASSED MED (g)
npm-audit 0 0 0 0 0 0 178ms 0 PASSED MED (g)
opengrep 0 0 0 0 0 0 <1ms 0 SKIPPED MED (g)
semgrep 0 0 0 0 0 0 13.4s 0 PASSED MED (g)
syft 0 0 0 0 0 0 2.1s 0 PASSED MED (g)

@mvangara10 mvangara10 merged commit 323e805 into awslabs:main Oct 15, 2025
8 checks passed
sunkavar pushed a commit to sasikiran-malladi/amazon-bedrock-agentcore-samples that referenced this pull request Oct 16, 2025
…slabs#442)

* Add browser tool with Strands integration tutorial and update contributors

- Add new tutorial: 03-browser-with-Strands with Jupyter notebook and requirements
- Update CONTRIBUTORS.md with new contributor information
- Update .gitignore to exclude .kiro and .vscode directories

* Update browser tool tutorial with renamed notebook

- Rename notebook to 01_getting_started-agentcore-browser-tool-with-strands.ipynb
- Update .gitignore with additional exclusions

* Remove complex timeout handling from Strands browser tutorial

- Simplified Step 4 invoke function by removing signal-based timeout protection
- Added simple comment about implementing timeout handling for slow websites
- Removed complex timeout_handler and invoke_with_timeout functions
- Updated notebook with executed results showing successful Tesla stock analysis
- Maintained clean error handling while simplifying timeout approach
- All cells executed successfully with real MarketWatch financial data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

01-tutorials 01-tutorials 05-AgentCore-tools 01-tutorials/05-AgentCore-tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants