agentcore memory browser #422

visitani · 2025-10-01T02:01:11Z

Amazon Bedrock AgentCore Samples Pull Request

Important

We strictly follow a issue-first approach, please first open an issue relating to this Pull Request.
Once this Pull Request is ready for review please attach review ready label to it. Only PRs with review ready will be reviewed.

Issue number:

Concise description of the PR

Changes to ..., because ...

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

I have reviewed the contributing guidelines
Add your name to CONTRIBUTORS.md
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Are you uploading a dataset?
Have you documented Introduction, Architecture Diagram, Prerequisites, Usage, Sample Prompts, and Clean Up steps in your example README?
I agree to resolve any issues created for this example in the future.
I have performed a self-review of this change
Changes have been tested
Changes are documented

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

Signed-off-by: Anil Gurrala <[email protected]>

mani-aiml · 2025-10-02T23:20:50Z

...ls/04-AgentCore-memory/03-advanced-patterns/03-memory-browser/scripts/get-aws-credentials.js

+    }
+
+    // Get current AWS region
+    let region = 'us-east-1';


Looks like its hard coded, please confirm.

removed the hardcode logic

mani-aiml · 2025-10-02T23:41:04Z

...AgentCore-memory/03-advanced-patterns/03-memory-browser/src/components/LongTermMemoryForm.js

+                    >
+                      <div className="namespace-type">
+                        <span className={`type-badge ${ns.type.toLowerCase()}`}>
+                          {ns.type === 'SEMANTIC' ? 'Facts' : 


What about if there is a custom strategy? Will this work or its hard coded?

yes it still works for custom strategy. But added few more lines to make it more user friendly

visitani · 2025-10-08T02:29:29Z

01-tutorials/04-AgentCore-memory/03-advanced-patterns/03-memory-browser/backend/app.py

+            return {
+                "memories": [],
+                "total_count": 0,
+                "source": "list_memory_records",
+                "memory_id": memory_id,
+                "error": f"Failed to access namespace '{query.namespace}': {str(e)}"
+            }


Eliminated all information exposure through exceptions

visitani · 2025-10-08T02:29:27Z

01-tutorials/04-AgentCore-memory/03-advanced-patterns/03-memory-browser/backend/app.py

+                return {
+                    "memory_id": memory_id,
+                    "namespaces": found_namespaces,
+                    "total_found": len(found_namespaces),
+                    "method": "fallback_pattern_based",
+                    "message": f"Found {len(found_namespaces)} namespaces using fallback method (get_memory_strategies failed: {str(e)})"
+                }


Eliminated all information exposure through exceptions

visitani · 2025-10-08T02:29:25Z

01-tutorials/04-AgentCore-memory/03-advanced-patterns/03-memory-browser/backend/app.py

+                return {
+                    "memory_id": memory_id,
+                    "namespaces": [],
+                    "total_found": 0,
+                    "error": f"Both get_memory_strategies and fallback failed: {str(e)} / {str(e2)}"
+                }


Eliminated all information exposure through exceptions

visitani · 2025-10-08T02:29:23Z

01-tutorials/04-AgentCore-memory/03-advanced-patterns/03-memory-browser/backend/app.py

+            return {
+                "valid": False,
+                "memory_id": query.memory_id,
+                "accessible": False,
+                "message": f"Memory ID validation failed: {str(e)}"
+            }


Eliminated all information exposure through exceptions

github-actions · 2025-10-02T23:52:32Z

Latest scan for commit: 52d7762 | Updated: 2025-10-02 23:52:32 UTC

Security Scan Results

Scan Metadata

Project: ASH
Scan executed: 2025-10-02T23:52:15+00:00
ASH version: 3.0.0

Summary

Scanner Results

The table below shows findings by scanner, with status based on severity thresholds and dependencies:

Column Explanations:

Severity Levels (S/C/H/M/L/I):

Suppressed (S): Security findings that have been explicitly suppressed/ignored and don't affect the scanner's pass/fail status
Critical (C): The most severe security vulnerabilities requiring immediate remediation (e.g., SQL injection, remote code execution)
High (H): Serious security vulnerabilities that should be addressed promptly (e.g., authentication bypasses, privilege escalation)
Medium (M): Moderate security risks that should be addressed in normal development cycles (e.g., weak encryption, input validation issues)
Low (L): Minor security concerns with limited impact (e.g., information disclosure, weak recommendations)
Info (I): Informational findings for awareness with minimal security risk (e.g., code quality suggestions, best practice recommendations)

Other Columns:

Time: Duration taken by each scanner to complete its analysis
Action: Total number of actionable findings at or above the configured severity threshold that require attention

Scanner Results:

PASSED: Scanner found no security issues at or above the configured severity threshold - code is clean for this scanner
FAILED: Scanner found security vulnerabilities at or above the threshold that require attention and remediation
MISSING: Scanner could not run because required dependencies/tools are not installed or available
SKIPPED: Scanner was intentionally disabled or excluded from this scan
ERROR: Scanner encountered an execution error and could not complete successfully

Severity Thresholds (Thresh Column):

CRITICAL: Only Critical severity findings cause scanner to fail
HIGH: High and Critical severity findings cause scanner to fail
MEDIUM (MED): Medium, High, and Critical severity findings cause scanner to fail
LOW: Low, Medium, High, and Critical severity findings cause scanner to fail
ALL: Any finding of any severity level causes scanner to fail

Threshold Source: Values in parentheses indicate where the threshold is configured:

(g) = global: Set in the global_settings section of ASH configuration
(c) = config: Set in the individual scanner configuration section
(s) = scanner: Default threshold built into the scanner itself

Statistics calculation:

All statistics are calculated from the final aggregated SARIF report
Suppressed findings are counted separately and do not contribute to actionable findings
Scanner status is determined by comparing actionable findings to the threshold

Scanner	C	L	Time	Action	Result	Thresh
bandit	1	3	1.0s	1	FAILED	MED (g)
cdk-nag	0	0	27.2s	0	PASSED	MED (g)
cfn-nag	0	0	11ms	0	PASSED	MED (g)
checkov	0	0	4.6s	0	PASSED	MED (g)
detect-secrets	0	0	985ms	0	PASSED	MED (g)
grype	0	0	<1ms	0	ERROR	MED (g)
npm-audit	0	0	161ms	0	PASSED	MED (g)
opengrep	0	0	<1ms	0	SKIPPED	MED (g)
semgrep	0	0	14.8s	0	PASSED	MED (g)
syft	0	0	2.0s	0	PASSED	MED (g)

Detailed Findings

Show 1 actionable findings

Finding 1: B104

Severity: HIGH
Scanner: bandit
Rule ID: B104
Location: 01-tutorials/04-AgentCore-memory/03-advanced-patterns/03-memory-browser/backend/app.py:1289-1290

Description:
Possible binding to all interfaces.

Code Snippet:

import uvicorn
    uvicorn.run(app, host="0.0.0.0", port=8000)

Report generated by Automated Security Helper (ASH) at 2025-10-02T23:52:09+00:00

* Transactional search images fixed, delete scripts * Add name to contributors * Renamed notebook, confirmed it works * Simplify README, get rid of local collector, change nb name * Update README.md Signed-off-by: seanslavichaws <[email protected]> * README update and fixed extra jinja2 spans * Add exclusions change to env example --------- Signed-off-by: seanslavichaws <[email protected]> Co-authored-by: Sean Slavich <[email protected]>

awslabs#423) * Adding LangGraph notebooks for agentcore checkpointer and memory store * fixing pip imports * feat: update math agent checkpointing file * docs: update documentation for human-in-the-loop sample * chore: rename math_agent notebook * refactor: update support-agent notebook structure * feat: update nutrition-assistant with custom strategy * feat: update nutrition assistant * docs: update readme * Fixing namespace in memory creation --------- Co-authored-by: Jack Gordley <[email protected]> Co-authored-by: Akarsha Sehwag <[email protected]> Co-authored-by: Akarsha Sehwag <[email protected]>

* Changes to support latest version of browser-use (0.7.9) * Changes based on comments and added name in contributors

…slabs#435) * Updated architecture diagram links in notebooks * fix: added agentcore-starterkit in requirements & updated memory manager notebook with cleaner docs --------- Co-authored-by: George Belsian <[email protected]>

* Updated observability samples to for Langfuse and Braintrust * Updated observability samples to for Langfuse and Braintrust --------- Signed-off-by: Rajesh Kumar Ravi <[email protected]> Co-authored-by: Rajesh Kumar Ravi <[email protected]>

…wslabs#415) * sagemakerai mlflow readme * sagemakerai mlflow readme * update readme --------- Signed-off-by: sandeepraveesh <[email protected]> Co-authored-by: Sandeep Raveesh <[email protected]>

review-notebook-app · 2025-10-14T04:39:23Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

agentcore memory browser

d8f437d

github-actions bot added 01-tutorials 01-tutorials 04-AgentCore-memory 01-tutorials/04-AgentCore-memory labels Oct 1, 2025

Update README.md

52d7762

Signed-off-by: Anil Gurrala <[email protected]>

mani-aiml reviewed Oct 2, 2025

View reviewed changes

github-advanced-security bot found potential problems Oct 2, 2025

View reviewed changes

akshseh and others added 10 commits October 14, 2025 00:39

fix: agentcore sdk version fix (awslabs#432)

3246f18

Changes to support latest version of browser-use (0.7.9) (awslabs#405)

3f22710

* Changes to support latest version of browser-use (0.7.9) * Changes based on comments and added name in contributors

Integrations/amazon-sagemakerai/sagemaker-mlflow-agentcore-runtime (a…

1ff661a

…wslabs#415) * sagemakerai mlflow readme * sagemakerai mlflow readme * update readme --------- Signed-off-by: sandeepraveesh <[email protected]> Co-authored-by: Sandeep Raveesh <[email protected]>

feat: iam auth with MCP Runtime (awslabs#438)

e8577ee

resolved comments

e7ab32d

removed memory id from exception messages

7a40903

visitani force-pushed the feature/agentcore-memory-browser branch from 3fa6c02 to 7a40903 Compare October 14, 2025 04:39

github-actions bot added 01-AgentCore-runtime 01-tutorials/01-AgentCore-runtime 05-AgentCore-tools 01-tutorials/05-AgentCore-tools 06-AgentCore-observability 01-tutorials/06-AgentCore-observability 07-AgentCore-E2E 01-tutorials/07-AgentCore-E2E 03-integrations 03-integrations labels Oct 14, 2025

agentcore memory browser #422

Are you sure you want to change the base?

agentcore memory browser #422

Uh oh!

Conversation

visitani commented Oct 1, 2025 • edited by mani-aiml Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Amazon Bedrock AgentCore Samples Pull Request

Concise description of the PR

User experience

Checklist

Acknowledgment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Check warning

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Check warning

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Check warning

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Check warning

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 2, 2025

Security Scan Results

Scan Metadata

Summary

Scanner Results

Detailed Findings

Finding 1: B104

Uh oh!

review-notebook-app bot commented Oct 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

visitani commented Oct 1, 2025 •

edited by mani-aiml

Loading