-
Notifications
You must be signed in to change notification settings - Fork 427
Byo container streaming example #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Byo container streaming example #266
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -0,0 +1,644 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this, or can we build using the CLI? looks like the script is pretty std?
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I looked for a way to build a custom container with the agentcore CLI and could not do it. In this case, we have to do it manually because we are dealing with multiple agent files.
@@ -0,0 +1,644 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #3. client = boto3.client('bedrock-agentcore-control')
can you see if python SDK works? Instead of bot3
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked and didn't find a way to deploy a custom container agent with the SDK, only an agent built with a single .py file and using the SDK's decorators. This is why we are using boto3.
@@ -0,0 +1,644 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #5. agent_core_client = boto3.client('bedrock-agentcore', region_name='us-east-1')
this can still be boto3, unlss you think there is value in doing everything from scratch, pelase do comment
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same case as the last comment. I did not find a way to make a call to a custom container agent through agentcore SDK. Only for agents with single .py files built with the SDK decorators.
56860f7
to
009cbb3
Compare
Signed-off-by: Neylson Crepalde <[email protected]>
Amazon Bedrock AgentCore Samples Pull Request
Instructions
Describe your changes
Issue ticket number and link
All Submissions:
New Example Submissions: