fix: mark chachapoly as unavailable with openssl-3.0-fips #5168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
force-pushed
the
openssl3fips_chachapoly
branch
from
fee40c8 to
ccfc980
Compare
goatgoose
approved these changes
Mar 7, 2025
CarolYeh910
approved these changes
Mar 7, 2025
dougch
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
related to #4993
Description of changes:
Unlike many of the non-fips options in s2n-tls, ciphers have an easily modified "is_available" method already implemented. Just mark chachapoly as unavailable rather than try to get the algorithm from a non-fips provider. If necessary, we can add the extra logic later to support chachapoly with fips.
Call-outs:
There's still one test failing, but it doesn't look related to chachapoly. Something to do with signing. I still need to investigate.
Testing:
Almost all the tests now work for openssl-3.0-fips! I switched from "-F" (run tests that match pattern) to "-E" (run tests that do NOT match pattern)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.