Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bindings): bump standard toolchain to latest #5163

Closed
wants to merge 2 commits into from

Conversation

lrstewart
Copy link
Contributor

@lrstewart lrstewart commented Mar 5, 2025

Release Summary:

Description of changes:

The Rust CI is failing with:

error[E0599]: no method named `is_none_or` found for enum `Option` in the current scope
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/symbolic-common-12.14.0/src/path.rs:57:32
   |
57 |             return path.get(2).is_none_or(is_windows_separator);
   |                                ^^^^^^^^^^ help: there is a method with a similar name: `is_none`
For more information about this error, try `rustc --explain E0599`.
error: could not compile `symbolic-common` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...

Looks like one of our dependencies, "symbolic", started using the is_none_or in their latest release: getsentry/symbolic@0ba5f9c That was JUST stabilized in 1.84.0.

Since this is standard instead of extended, we can just bump our toolchain rather than pin :)

Testing:

CI now passes, specifically "Standard Workspace Tests" in the generate action.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Mar 5, 2025
@lrstewart lrstewart marked this pull request as ready for review March 5, 2025 21:20
@CarolYeh910 CarolYeh910 enabled auto-merge March 5, 2025 22:39
@lrstewart lrstewart disabled auto-merge March 5, 2025 22:42
@lrstewart lrstewart closed this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants