Skip to content

chore(bindings): change in rustup behavior #5160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dougch merged 3 commits into from
Mar 4, 2025
Merged

chore(bindings): change in rustup behavior #5160

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7431deb
chore(bindings): change in rustup behavior
dougch Mar 3, 2025
40a75cd
toolchain update needed for standard too
dougch Mar 4, 2025
0e217fe
explicitly add rustfmt
dougch Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bindings/rust/extended/generate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ cp -r \

# generate the bindings modules from the copied sources
pushd generate
# Behavior change from https://github.com/rust-lang/rustup/pull/3985
rustc --version || rustup toolchain install
Copy link
Copy Markdown
Contributor

@jmayclin jmayclin Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On one hand it feels weird to install the toolchain in the script, but I guess that was the previous behavior?

Approving because we only expect this to be run by s2n-tls developers, so it should be a totally internal change.

Copy link
Copy Markdown
Contributor Author

@dougch dougch Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it seems like this should be an existing action that just works. After unblocking the GHA runs, we should review.

rustup component add rustfmt
cargo run -- ../s2n-tls-sys
popd

Expand All @@ -53,6 +56,7 @@ cargo publish --dry-run --allow-dirty --all-features
popd

pushd ../standard/integration
rustc --version || rustup toolchain install
cargo run
popd

Expand Down