Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix redundant return #5150

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Conversation

jmayclin
Copy link
Contributor

@jmayclin jmayclin commented Feb 27, 2025

Description of changes:

#1893

Solved using find and replace

Find

END_TEST\(\);\n.*return 0

Replace

END_TEST();

Testing:

All tests should pass

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Feb 27, 2025
@jmayclin jmayclin marked this pull request as ready for review February 27, 2025 18:55
@jmayclin jmayclin requested review from dougch and goatgoose February 27, 2025 18:55
@lrstewart
Copy link
Contributor

Should we add a grep_simple_mistakes.sh for this? Otherwise we could add back some returns

@jmayclin
Copy link
Contributor Author

jmayclin commented Feb 28, 2025

I'm generally not inclined to add it in grep_simple_mistakes.sh since this removes all instances of it. My personal hypothesis is inconsistency is viral. Someone copy-pastes a file and edits it, and it goes from there. Since there are now 0 instances of the pattern, I'm less worried about it appearing again.

@jmayclin jmayclin added this pull request to the merge queue Mar 6, 2025
Merged via the queue into aws:main with commit 9c85d3c Mar 6, 2025
47 checks passed
@jmayclin jmayclin deleted the consistent-return branch March 6, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants