-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add alternative EVP signing method #5141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
lrstewart
commented
Feb 21, 2025
Comment on lines
+109
to
+110
POSIX_GUARD(s2n_pkey_sign(priv, S2N_SIGNATURE_RSA_PSS_PSS, &sign_hash, &signature_data)); | ||
POSIX_GUARD(s2n_pkey_verify(pub, S2N_SIGNATURE_RSA_PSS_PSS, &verify_hash, &signature_data)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this, s2n_evp_signing_test can't load the RSA-PSS certificate it needs for testing.
dougch
approved these changes
Feb 24, 2025
554ddf3
to
5f93441
Compare
goatgoose
reviewed
Feb 25, 2025
goatgoose
approved these changes
Feb 26, 2025
jmayclin
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
related to #5105
Description of changes:
Final required change for #5105. This adds the new non-FIPS-140-3 EVP signing method and switches all libcryptos except awslc-fips to use it.
The state of the library after this change matches the desired state described in #5105, which is:
Testing:
I added s2n_evp_signing_test to the Openssl3fipsWIP build. It's nice to note that after this change, only 12/274 tests are failing for openssl-3.0-fips. A quick spot check doesn't suggest any of them are related to this change.
I also added known-value tests to s2n_evp_signing_test. That's important for a couple reasons:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.