-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ruff): apply formatting and integrate into CI #5138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! But for the sake of documentation, we probably want to add some context to the PR description.
- What changes are done manually?
- What changes were automated?
- What command was used to make the automated changes?
- Why is this change being made? Why replace pep8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such consistency...nice.
minor nit: can you also cleanup the pep8 config? https://github.com/aws/s2n-tls/blob/main/.pep8
Co-authored-by: James Mayclin <[email protected]>
Resolved issues:
resolves #5027
Description of changes:
Manual changes:
Automated changes:
uv run ruff format
to format all files in tests/integrationv2.Why replace autopep8 with ruff?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.