fix: update callback return value #5136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
A successful cert validation callback should return only
S2N_SUCCESS
. Previously, both 0 and any positive return value were considered successful.Description of changes:
This is a follow-up change on PR #5110
Per our documentation,
s2n_cert_validation_callback
should returnS2N_SUCCESS
on success. However, the old behavior accepted both 0 and positive values. This PR aims to fix this inconsistency.Testing:
Confirmed
s2n_cert_validation_callback_test
passed with this changeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.