fix(bindings): remove mutation behind Arc #5124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
CertificateChainHandle
In
connection.rs
, we essentially mutate aCertificateChainHandle
which is behindArc<CertificateChainHandle>
. This does not seem correct.Additionally, the most accurate place to tag the lifetime is on the underlying
CertificateChainHandle
, which already has theis_owned
field.Call-outs:
This refactor is being done to simplify the addition of an application-level CertificateChainContext.
Testing:
This is a refactor. All existing tests should continue to pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.