Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate build from test #5122

Closed
wants to merge 1 commit into from
Closed

Conversation

dougch
Copy link
Contributor

@dougch dougch commented Feb 18, 2025

Release Summary:

Resolved issues:

none

Description of changes:

Codebuild emits timing metrics to CloudWatch per phase. To capture just the build timing, I need a singleton job (not batch) where build and test can be separated. The recent kTLS job is a good candidate.

Call-outs:

There is only one phase after build, so the ASAN build/test is running with the regular tests.

Testing:

locally- this buildspec change should run in CI as well.

Remember:

  • Any change to the library source code should at least include unit tests.
  • Any change to the core stuffer or blob methods should include CBMC proofs.
  • Any change to the CI or tests should:
    1. prove that the test succeeds for good input
    2. prove that the test fails for bad input (eg, a test for memory leaks fails when a memory leak is committed)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Feb 18, 2025
@dougch
Copy link
Contributor Author

dougch commented Feb 18, 2025

close for now

@dougch dougch closed this Feb 18, 2025
@dougch dougch deleted the ktls_timing branch February 18, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant