Session ticket tls12 back up #5063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
January 3, 2025 23:25
* checked the chosen psk keying material expiration.
* add reference check for conn->config * makes the s2n_generate_ticket_lifetime function more readable * fix the chosen_psk logic
* assert unsigned integer subtractions * fix testing: ensure that keying material expiration is one week after current time
* use s2n_stuffer_reserve_uint32 to skip the session ticket lifetime calculation. * add s2n_stuffer_reserve_uint32 to s2n_stuff.h
* specific errno for lifetime is zero
* renaming variable names in generate lifetime function
* use simple calculation to get key intro time
* add tests for zero lifetime case in tls 1.2 and 1.3
* fix the PSK lifetime is shortest
* makes it to be half a week
* query real time two times for key intro time and current time without actually creating a key
* check for server keying material and PSK only for TLS1.3
* the client should not accept and should delete the nst if nst's lifetime has expired
boquan-fang
force-pushed
the
session-ticket-tls12-back-up
branch
5 times, most recently
from
b5e1a99 to
75cb3f4
Compare
added 2 commits
January 27, 2025 20:15
boquan-fang
force-pushed
the
session-ticket-tls12-back-up
branch
from
75cb3f4 to
e972c89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing:
Merge to main and run the CI. This draft PR is for testing purpose only.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.