refactor: cleanup CBMC proofs after #5048 #5058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jouho
approved these changes
Jan 23, 2025
goatgoose
approved these changes
Jan 23, 2025
CarolYeh910
pushed a commit
to CarolYeh910/s2n-tls
that referenced
this pull request
Jan 24, 2025
johubertj
pushed a commit
to johubertj/s2n-tls
that referenced
this pull request
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
Finish up the cleanup for #5048 (comment)
Description of changes:
Delete the empty s2n_evp.c file, and fix all the CBMC proofs that refer to it or the deleted methods.
Testing:
CBMC proofs continue to pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.