Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bin): remove references to FIPS_mode_set #5026

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

lrstewart
Copy link
Contributor

Release Summary:

Description of changes:

Hopefully last of the openssl-1.0.2-fips cleanup. FIPS_mode_set was only required for openssl-1.0.2-fips, not for awslc or openssl3.

Testing:

I verified with a search that the only remaining references to FIPS_mode_set are in the s2n_fips.c comment discussing past behavior.

s2nd when built with awslc-fips:

./build/bin/s2nd --enter-fips-mode localhost 8888
libcrypto: AWS-LC FIPS 2.0.17
s2nd entered FIPS mode

s2nd when built with openss-1.1.1:

./build/bin/s2nd --enter-fips-mode localhost 8888
libcrypto: OpenSSL 1.1.1x-dev  xx XXX xxxx
FIPS mode not enabled: libcrypto does not support FIPS

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Jan 11, 2025
@lrstewart lrstewart marked this pull request as ready for review January 13, 2025 22:29
@lrstewart lrstewart requested review from maddeleine and jouho January 13, 2025 22:29
@lrstewart lrstewart added this pull request to the merge queue Jan 14, 2025
Merged via the queue into aws:main with commit e6949fd Jan 14, 2025
43 checks passed
@lrstewart lrstewart deleted the no102fips branch January 14, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants