-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add coverage for all ticket formats #4997
fix: add coverage for all ticket formats #4997
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! From your new coverage report, are there any concerns that we're only covering the server code path and not the client code path?
@@ -44,7 +44,6 @@ int s2n_fuzz_test(const uint8_t *buf, size_t len) | |||
/* There are only a few valid formats for session tickets; this ensures the | |||
* format version is at or below S2N_SERIALIZED_FORMAT_TLS12_V3, which will | |||
* keep the test checking mostly valid paths. */ | |||
randval = randval % S2N_SERIALIZED_FORMAT_TLS12_V3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
Since we're removing this line, let's go ahead and clean up the comment/setup that is no longer used.
The result seems to make sense because the connection mode is set to
|
Release Summary:
Resolved issues:
resolves #4965
Description of changes:
There are two changes in this PR:
Remove the manual setting of session ticket formats in
s2n_deserialize_resumption_state_test.c
. We no longer make assumptions about the possible format versionsUpdate the path to coverage reports in
Readme
Call-outs:
N/A
Testing:
Generated fuzz coverage reports locally and confirmed that
S2N_SERIALIZED_FORMAT_TLS12_V3
is coveredBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.