Refactor: change is_available return type to bool in s2n_cipher struct #4630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
reviewed
Jun 26, 2024
jouho
changed the title
maddeleine
approved these changes
Jul 3, 2024
lrstewart
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Part of #3983
Description of changes:
is_availablefors2n_cipherstruct fromuint8_ttobools2n-tls/crypto/s2n_cipher.h
Line 85 in d538d0a
Call-outs:
Testing:
All unit tests passed. Will address CI failures if any.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.