bindings: use aws-lc-rs instead of aws-lc-sys #4415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
bindings-aws-lc-rs
branch
from
b5450ec to
12eef9c
Compare
camshaft
force-pushed
the
bindings-aws-lc-rs
branch
from
12eef9c to
76f318c
Compare
WesleyRosenblum
approved these changes
Feb 14, 2024
maddeleine
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
After aws/aws-lc-rs#335 was merged, we can now switch to depend on
aws-lc-rsinstead ofaws-lc-sys. This has the following benefits:aws-lc-rsoraws-lc-sys(e.g. s2n-quic)aws-lc-rsexposes afipsfeature.Testing:
The existing CI tests should continue to pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.