ci: Disable broken rust dry-runs #4384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmayclin
approved these changes
Jan 27, 2024
camshaft
approved these changes
Jan 27, 2024
jmayclin
pushed a commit
to jmayclin/s2n-tls
that referenced
this pull request
Jan 31, 2024
jmayclin
pushed a commit
to jmayclin/s2n-tls
that referenced
this pull request
Jan 31, 2024
jmayclin
pushed a commit
to jmayclin/s2n-tls
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
While it would be nice to be able to do these dry-runs, they prevent us from making any changes to multiple crates without releases in between each change. For example, if I add a new method to s2n_tls::Connection, I can't use it in s2n_tls_tokio until I release s2n_tls. Because the dry-run uses the dependencies from crates.io, it can't find the new method. See https://github.com/aws/s2n-tls/actions/runs/7632801705/job/20793749145
Call-outs:
I suppose this wouldn't be a blocker if we bumped the version in github immediately after a release instead of just before a release? But as far as I know that's not the standard way to handle versioning in Rust (not the way s2n-quic does it either, at least) and there might be other issues with that model. Also, that would still be equivalent to removing the dry-run, because the dry-run would never run.
Testing:
I have another PR that failed because of this: #4374 Removing the dry runs fixed it.
I also checked that a change in s2n-tls-sys would have the same effect on a change in s2n-tls.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.