Skip to content

Conversation

@engedaam
Copy link
Contributor

Fixes #N/A

Description

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@engedaam engedaam requested a review from a team as a code owner October 23, 2025 20:07
@engedaam engedaam requested a review from edibble21 October 23, 2025 20:07
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18760582975

Details

  • 117 of 122 (95.9%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 65.134%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/providers/amifamily/ami.go 6 7 85.71%
pkg/fake/ec2api.go 87 91 95.6%
Totals Coverage Status
Change from base Build 18359242365: 0.1%
Covered Lines: 5838
Relevant Lines: 8963

💛 - Coveralls

Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@engedaam engedaam merged commit eac1f3c into aws:release-v1.2.x Oct 23, 2025
14 checks passed
@engedaam engedaam deleted the hash-v1.2 branch October 23, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants