fix: prevent hash collisions while resolving subnets, security groups and AMIs from nodeclass selectors #8632

saurav-agarwalla · 2025-10-16T02:30:44Z

Description

Moves away from hashstructure.Hash to ensure that filters are properly resolved without hash collisions and hence prevents hash collisions when resolving subnets, security groups and AMIs.

How was this change tested?

make presubmit

Does this change impact docs?

Yes, PR includes docs updates
Yes, issue opened: #
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

netlify · 2025-10-16T02:30:49Z

✅ Deploy Preview for karpenter-docs-prod canceled.

Name	Link
🔨 Latest commit	`53d5d12`
🔍 Latest deploy log	https://app.netlify.com/projects/karpenter-docs-prod/deploys/68f31fcdcbddae0008a2779a

github-actions · 2025-10-16T02:33:05Z

Preview deployment ready!

Preview URL: https://pr-8632.d18coufmbnnaag.amplifyapp.com

Built from commit 53d5d12459abb9b251423eb7a59b9b43451a20b6

saurav-agarwalla

/karpenter snapshot

coveralls · 2025-10-16T02:39:03Z

Pull Request Test Coverage Report for Build 18611125649

Details

31 of 31 (100.0%) changed or added relevant lines in 7 files are covered.
13 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.04%) to 67.476%

Files with Coverage Reduction	New Missed Lines	%
pkg/fake/iamapi.go	5	57.69%
pkg/providers/instanceprofile/instanceprofile.go	8	81.22%

Totals
Change from base Build 18576086927:	-0.04%
Covered Lines:	7780
Relevant Lines:	11530

💛 - Coveralls

github-actions · 2025-10-16T02:39:54Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-921ee6296cd88410b1c73e43f5a36f0869730e00.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-921ee6296cd88410b1c73e43f5a36f0869730e00" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

saurav-agarwalla

/karpenter snapshot

github-actions · 2025-10-16T17:34:06Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-6942b7f7f14dea4d309e7e223839e0e9de1a93d7.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-6942b7f7f14dea4d309e7e223839e0e9de1a93d7" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

saurav-agarwalla

/karpenter snapshot

github-actions · 2025-10-17T22:33:10Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-f575746f1bcc72f97daec5dde32d98e78b070ae0.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-f575746f1bcc72f97daec5dde32d98e78b070ae0" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

pkg/providers/amifamily/types.go

pkg/utils/utils.go

saurav-agarwalla

/karpenter snapshot

github-actions · 2025-10-18T01:53:13Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-00d90eb8a59a84c479b32fa025df7c5308580285.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-00d90eb8a59a84c479b32fa025df7c5308580285" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

pkg/providers/amifamily/ami.go

jmdeal

Tentatively approved, my only comment is non-blocking

… and AMIs from nodeclass selectors

jmdeal

LGTM 🚀

saurav-agarwalla requested a review from a team as a code owner October 16, 2025 02:30

saurav-agarwalla requested a review from AndrewMitchell25 October 16, 2025 02:30

saurav-agarwalla commented Oct 16, 2025

View reviewed changes

ci: Fix failing AMI tests after 1.34 upgrade

19e7e9a

saurav-agarwalla force-pushed the main branch 2 times, most recently from 0a417f3 to f575746 Compare October 17, 2025 22:27

saurav-agarwalla commented Oct 17, 2025

View reviewed changes

ellistarn reviewed Oct 17, 2025

View reviewed changes

pkg/providers/amifamily/types.go Outdated Show resolved Hide resolved

ellistarn reviewed Oct 17, 2025

View reviewed changes

pkg/providers/amifamily/types.go Outdated Show resolved Hide resolved

ellistarn reviewed Oct 17, 2025

View reviewed changes

pkg/utils/utils.go Show resolved Hide resolved

ellistarn approved these changes Oct 17, 2025

View reviewed changes

saurav-agarwalla force-pushed the main branch from f575746 to 00d90eb Compare October 18, 2025 01:47

saurav-agarwalla commented Oct 18, 2025

View reviewed changes

jmdeal reviewed Oct 18, 2025

View reviewed changes

pkg/providers/amifamily/ami.go Show resolved Hide resolved

jmdeal previously approved these changes Oct 18, 2025

View reviewed changes

fix: prevent hash collisions while resolving subnets, security groups…

53d5d12

… and AMIs from nodeclass selectors

saurav-agarwalla dismissed jmdeal’s stale review via 53d5d12 October 18, 2025 05:04

saurav-agarwalla force-pushed the main branch from 00d90eb to 53d5d12 Compare October 18, 2025 05:04

jmdeal approved these changes Oct 18, 2025

View reviewed changes

saurav-agarwalla merged commit 2c931af into aws:main Oct 18, 2025
19 checks passed

fix: prevent hash collisions while resolving subnets, security groups and AMIs from nodeclass selectors #8632

fix: prevent hash collisions while resolving subnets, security groups and AMIs from nodeclass selectors #8632

Conversation

saurav-agarwalla commented Oct 16, 2025

Uh oh!

netlify bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for karpenter-docs-prod canceled.

Uh oh!

github-actions bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

saurav-agarwalla left a comment

Choose a reason for hiding this comment

Uh oh!

coveralls commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 18611125649

Details

💛 - Coveralls

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

saurav-agarwalla left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

saurav-agarwalla left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

saurav-agarwalla left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 18, 2025

Uh oh!

Uh oh!

jmdeal left a comment

Choose a reason for hiding this comment

Uh oh!

jmdeal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

netlify bot commented Oct 16, 2025 •

edited

Loading

github-actions bot commented Oct 16, 2025 •

edited

Loading

coveralls commented Oct 16, 2025 •

edited

Loading