-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add sampleLimit to ServiceMonitor #8557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add more details about your usecase? I understand the general need for limiting the samples, but is your goal to up the default or to limit it because you're hitting scrape timeouts?
We have a global sample limit configured on prometheus to 10k, which causes it to fail to scrape karpenter, since it exposes a lot more than that (around 70k IIRC). We still want to have the default scrape limit on prometheus to protect against too high metric cardinality on our services, but allow specific services to override the limit when needed, like here |
Preview deployment ready! Preview URL: https://pr-8557.d18coufmbnnaag.amplifyapp.com Built from commit |
Pull Request Test Coverage Report for Build 18603766286Details
💛 - Coveralls |
I think that usecase makes sense. Let me double check with some other team members to make sure I'm not missing anything and we can get this merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, after discussion with the team looks like we're good to go, just update the branch to be up to date and I'll approve!
Updated 👍 |
title: Add sampleLimit to ServiceMonitor
chore: Support optionally setting the prometheus scrape sampleLimit parameter on the ServiceMonitor
How was this change tested?
Running
helm template
with various valuesDoes this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.