-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Added settings.kubernetes.hostname-override-source to bottlerocketsettings.go #8549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
|
Thanks for the PR! I'm not sure I specifically understand the usecase. Could you include an example of how and why someone would use this new setting? I'm trying to find out why someone one want to configure this, or if we should just set it by default instead Also if theres a better documentation link than https://bottlerocket.dev/en/os/1.44.x/api/settings/kubernetes/ that'd be nice to include in the description. I can't find the setting this is referring to specifically. |
|
@DerekFrank Unfortunately the Bottlerocket are currently missing this parameter, already addressed it. |
|
Synced with the team, looks like we're willing to accept this change but you'll have to update the branch :) |
Done. |
|
Preview deployment ready! Preview URL: https://pr-8549.d18coufmbnnaag.amplifyapp.com Built from commit |
Pull Request Test Coverage Report for Build 18919770533Details
💛 - Coveralls |
This PR includes
settings.kubernetes.hostname-override-sourcein BottlerocketConfig struct to allow resource-based K8s node naming with just the EC2 instance ID.It uses a yet undocumented Bottlerocket feature, see Bottlerocket issue Add documentation for settings.kubernetes.hostname-override-source #547.
Fixes #8548
Description
How was this change tested?
Yes, successfully tested using:
Prerequisites:
Note: This is important to successfuly register K8s node object by kubelet
Run patched Karpenter locally with
make run, launched instance , SSM into instance and got:Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.