Skip to content

Conversation

@himani2411
Copy link
Contributor

@himani2411 himani2411 commented Oct 31, 2025

Description of changes

StoragePass
Define the password used to gain access to the database to store the job accounting data. The '#' character is not permitted in a password.

When running manually

sudo ./update_slurm_database_password.sh
Reading password from /opt/slurm/etc/slurm_parallelcluster_slurmdbd.conf
Reading password from AWS Secrets Manager: arn:aws:secretsmanager:ap-south-1:447714826191:secret:AccountingClusterAdminSecre-xImvFgSN8JqP-BXWv1l
You cannot use the # character in the database password as Slurm does not support it with StoragePass configuration paramter in /opt/slurm/etc/slurm_parallelcluster_slurmdbd.conf. You can get more details in https://slurm.schedmd.com/slurmdbd.conf.html
[ec2-user@ip-192-168-0-190 slurm]$

Related to aws/aws-parallelcluster#5437

Tests

  • Script Test
  • test_slurm_accounting

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

password_from_secrets_manager=$(aws secretsmanager get-secret-value --secret-id ${SECRET_ARN} --region ${REGION} --query 'SecretString' --output text)

if [[ "${password_from_secrets_manager}" =~ '#' ]]; then
echo "You cannot use the # character in the database password as Slurm does not support it with $SLURMDBD_PROPERTY configuration paramter in $SLURMDBD_CONFIG_FILE. You can get more details in https://slurm.schedmd.com/slurmdbd.conf.html"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[minor] Better to avoid URLs in error messages because they may change over time, espcieally if they are not under our control. I suggest to simply say something like 'Please, refer to the official documentation from SchedMD for more details.'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@himani2411 himani2411 merged commit c3c60a6 into aws:develop Nov 3, 2025
26 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants