Open
Conversation
a99ce8c to
0373aa5
Compare
0373aa5 to
3a4ae06
Compare
3a4ae06 to
fe6ad54
Compare
fe6ad54 to
251f318
Compare
3daca3f to
bcec71f
Compare
bcec71f to
bd838b3
Compare
bd838b3 to
5842844
Compare
5842844 to
de29a8d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3042 +/- ##
=======================================
Coverage 78.36% 78.37%
=======================================
Files 689 689
Lines 121141 121140 -1
Branches 16974 16974
=======================================
+ Hits 94938 94944 +6
+ Misses 25306 25300 -6
+ Partials 897 896 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
reviewed
Mar 4, 2026
justsmth
reviewed
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ENABLE_DIST_PKGandENABLE_DIST_PKG_OPENSSL_SHIMCMake options to support Linux distribution packaging where AWS-LC must coexist alongside OpenSSL.ENABLE_DIST_PKGis enabled, headers are installed under include/aws-lc/ (cohabitant headers) and libraries are built with an-awslcsuffix (e.g.,libcrypto-awslc.so), preventing file conflicts with other providersENABLE_DIST_PKG_OPENSSL_SHIMflag createslibcrypto.so,libssl.so,include/openssl, andopenssl.pcsymlinks or files for drop-in OpenSSL compatibilityopenssl.pc.inwithproduct.pc.in, makes library names dynamic in .pc templates, and addsLibs.privatefor pthread linkage to make pkg-config work correctly for static builds as well.PERFORM_SONAME_BUILDinternal logic with withSET_LIB_SONAMEandCOHABITANT_HEADERSvariables for clearer intent; adds deprecation warning forENABLE_PRE_SONAME_BUILDas we should remove it in a future release.NAMELINK_SKIPtoNAMELINK_COMPONENTDevelopment (CMake 3.12+) with a fallback for older CMake versionsTesting
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.