Add Optimized and HOL Light verified AVX2 Keccak x4#3020
Open
manastasova wants to merge 2 commits intoaws:mainfrom
Open
Add Optimized and HOL Light verified AVX2 Keccak x4#3020manastasova wants to merge 2 commits intoaws:mainfrom
manastasova wants to merge 2 commits intoaws:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3020 +/- ##
==========================================
- Coverage 78.51% 78.34% -0.18%
==========================================
Files 689 689
Lines 121018 121019 +1
Branches 16999 16969 -30
==========================================
- Hits 95021 94809 -212
- Misses 25097 25315 +218
+ Partials 900 895 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9430212 to
ee4fc2f
Compare
Contributor
|
@manastasova is this ready for review or waiting on the s2n-bignum merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Import AVX2 Optimized and HOL Light verified 4x Keccak permutation awslabs/s2n-bignum#354
NOTE:: Once awslabs/s2n-bignum#354 is merged, the assembly files would be imported directly with the importer script.
Description of changes:
This PR introduces an optimized AVX2 implementation of the Keccak-f[1600] x4 permutation, formally verified using HOL Light. This batched Keccak implementation processes four independent Keccak permutations in parallel using AVX2 SIMD instructions, significantly accelerating the core hash operations underlying ML-KEM (FIPS 203) and ML-DSA (FIPS 204).
The 4-way parallel Keccak permutation is a critical building block for lattice-based cryptographic schemes, as it is heavily used in:
Performance Results
The optimization delivers substantial throughput improvements across all tested EC2 instance types:
Average Speedups by Algorithm Family:
Notable highlights:
Call-outs:
Testing:
./crypto/crypto_testtool/bssl speed -filter "ML-KEM"tool/bssl speed -filter "MLDSA"More Performance Data
EC2 c7i
EC2 c7a
EC2 c6i
EC2 c6a
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.