Skip to content

Fix Windows/ARM64 assembly build#1697

Merged
justsmth merged 4 commits intoaws:mainfrom
justsmth:win-msbuild-asm
Jul 15, 2024
Merged

Fix Windows/ARM64 assembly build#1697
justsmth merged 4 commits intoaws:mainfrom
justsmth:win-msbuild-asm

Conversation

@justsmth
Copy link
Contributor

@justsmth justsmth commented Jul 10, 2024

Issues:

Description of changes:

  • When building for Windows/ARM64 with the "Visual Studio" generator (instead of Ninja) the "*.S" assembly source files for libraries are ignored.
  • This change provides a custom command to assemble the require objects files and adds them to the list of sources for the library.

Call-outs:

Testing

  • I've added CI tests to build for Windows using the "Visual Studio" generator.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.22%. Comparing base (a0e8da9) to head (f56f9f5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1697      +/-   ##
==========================================
- Coverage   78.22%   78.22%   -0.01%     
==========================================
  Files         571      571              
  Lines       95519    95519              
  Branches    13700    13699       -1     
==========================================
- Hits        74721    74720       -1     
- Misses      20188    20191       +3     
+ Partials      610      608       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth force-pushed the win-msbuild-asm branch 4 times, most recently from fe81623 to 1f94aa2 Compare July 11, 2024 12:47
@justsmth justsmth changed the title [DRAFT] Fix Windows/ARM64 assembly build Fix Windows/ARM64 assembly build Jul 11, 2024
@justsmth justsmth marked this pull request as ready for review July 11, 2024 13:07
@justsmth justsmth requested a review from a team as a code owner July 11, 2024 13:07
@justsmth justsmth requested review from andrewhop and skmcgrail July 11, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants