Skip to content

LSP script support jump to definition for sagemaker sdk #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

LSP script support jump to definition for sagemaker sdk #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
432a351
Add support for jump to definition source files in studio
Aug 17, 2022
236c330
Add support for jump to definition source files in studio
Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions scripts/install-lsp-features/on-jupyter-server-start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,16 @@ pip install jupyterlab-lsp \
# https://jupyterlab-lsp.readthedocs.io/en/latest/Language%20Servers.html
jlpm add --dev bash-language-server dockerfile-language-server-nodejs

# Install sagemaker sdk & scikit-learn onto jlab server for source code jump to definition
pip install sagemaker scikit-learn
Copy link
Contributor

@athewsey athewsey Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess difficult to know where to draw the line on what libraries to install for this purpose... Would be ideal if jupyterlab-lsp could properly use the kernel environments instead, but agree demoing sagemaker + one third-party could be a nice compromise to show users what's possible

# Create an lsp symlink directory so jupyterlab-lsp can open source-files not found in user home directory
mkdir .lsp_symlink
Copy link
Contributor

@athewsey athewsey Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails on 2nd run onwards because the folder already exists.

When I tried adding the -p flag to allow this, I got an error in the line below due to the target already existing and being a (symlink to a) directory:

ln: failed to create symbolic link ‘.lsp_symlink/opt/opt’: Permission denied

So instead I'm currently testing with:

rm -rf .lsp_symlink && mkdir .lsp_symlink

ln -s /opt .lsp_symlink/opt
# Enable opening of symlink files found in the hidden directory `.lsp_symlink/`
echo yes | jupyter server --generate-config
sed -i '1i c.ContentsManager.allow_hidden = True' .jupyter/jupyter_server_config.py


# This configuration override is optional, to make LSP "extra-helpful" by default:
CMP_CONFIG_DIR=.jupyter/lab/user-settings/@krassowski/jupyterlab-lsp/
CMP_CONFIG_FILE=completion.jupyterlab-settings
Expand Down