Skip to content

Conversation

@AdnaneKhan
Copy link

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@liwadman
Copy link
Contributor

liwadman commented Oct 21, 2025

Hey Adnan, thank you for your submission.

I have no concerns on the modification for notifier task as it's pretty uninteresting and benign, but I've forwarded this to my colleague who is more familiar with our repo sync setup to understand the specifics of what we're doing with that and the implications of being more explicit with the permissions and to do some testing.

@liwadman liwadman requested a review from lauradreith October 21, 2025 16:31
Remove write permissions as workflow uses a token from secret.
@AdnaneKhan
Copy link
Author

Hey Adnan, thank you for your submission.

I have no concerns on the modification for notifier task as it's pretty uninteresting and benign, but I've forwarded this to my colleague who is more familiar with our repo sync setup to understand the specifics of what we're doing with that and the implications of being more explicit with the permissions and to do some testing.

Thanks! Based on the workflow if it still uses the PAT then no permissions are needed (as it uses the PAT for auth). If using the GitHub token it'll need contents: write + pull-requests: write (if it is making a PR on this repo - if making a PR on another repo it will always need the PAT).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants