This repository was archived by the owner on Apr 25, 2024. It is now read-only.
201 monitoring update#518
Open
CharlyF wants to merge 5 commits intoaws-samples:masterfrom
Open
Conversation
added 5 commits
July 6, 2018 16:11
|
Prometheus is not working in this example without the RBAC changes from @CharlyF. This whole PR looks good. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
#407
#491
Also bumps ksm for more metrics and Prom-operator.
Description of changes:
Clarify the README.md for Cloud9 users. The user needs to modify the proxy command to see the Grafana and Prometheus dashboards.
Also fixes the RBAC issue for the prometheus deployment.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.