fix(cfn-guard): canonicalize creates invalid json [DO NOT MERGE / REVIEW RUNNING AGAINST CI] #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we update the massaging in the TS lib once we change this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 536
The issue appears to be with paths. I encountered something similar in the TS lib but massaged the data in there as I assumed it was an issue with those changes and not guard itself.
Description of changes:
Use an OSString instead of a canonicalized PathBuf converted to a string. It generated invalid characters for JSON and SARIF.
rust-lang/rust#81045 (comment)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license