feat(amplify-data): enhance discussion of split schema files #8228
Conversation
|
|
||
| For the latest updates and potential future enhancements, please track the ongoing discussion in [GitHub Issue #3036](https://github.com/aws-amplify/amplify-category-api/issues/3036). | ||
| <Callout info> | ||
| Amplify directives are not supported on extended type definitions themselves (e.g., `extend type Todo @auth...`), or on fields of types other than `Query`, `Mutation`, and `Subscription`. |
There was a problem hiding this comment.
the latter part of the callout reads a bit odd to me but it may just be me 😅
or on fields of types other than
Query,Mutation, andSubscription
is this referring to fields in non-model types?
There was a problem hiding this comment.
Both model and non-model types are not supported. I agree the syntax is a bit convoluted -- can you suggest clearer wording?
There was a problem hiding this comment.
is it accurate to say "or on fields of extended types other than..."?
There was a problem hiding this comment.
Yes, it is more accurate. I'm not sure it's any clearer, but would this work?
Amplify directives are not supported on extended type definitions themselves (e.g.,
extend type Todo @auth...), or on fields of extended types other thanQuery,Mutation, andSubscription.
There was a problem hiding this comment.
Yes that works! When I read it initially I thought of model types despite the preceding context
Description of changes:
Builds on #8221 and enhances the discussion of split schema files, especially with respect to directive support on fields of extended types.
extendkeywordRelated GitHub issue #, if available:
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://docs.amplify.aws/)HTML:
<a href="https://docs.amplify.aws/">link</a>When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.