fix Unsafe shell command constructed from library input index
#14203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amplify-cli/packages/amplify-e2e-core/src/utils/index.ts
Line 81 in c85ed14
fix the issue should avoid constructing the shell command as a single string and instead pass the command and its arguments as an array to
execa.commandSync
. This approach prevents the shell from interpreting special characters in the input, mitigating the risk of command injection. Specifically:execa
'sexeca.sync
method with the command and arguments passed as separate parameters.Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.