chore(amplify-util-uibuilder): remove codegen-ui usage#13234
Open
Jshhhh wants to merge 2 commits intoaws-amplify:devfrom
Open
chore(amplify-util-uibuilder): remove codegen-ui usage#13234Jshhhh wants to merge 2 commits intoaws-amplify:devfrom
Jshhhh wants to merge 2 commits intoaws-amplify:devfrom
Conversation
Jshhhh
force-pushed
the
remove-codegenui
branch
from
6ef6c86 to
ad4bf57
Compare
letsbelopez
reviewed
Sep 19, 2023
packages/amplify-util-uibuilder/src/commands/utils/codegen-ui-dependency-provider.ts
Show resolved
Hide resolved
letsbelopez
reviewed
Sep 19, 2023
sobolk
reviewed
Sep 19, 2023
Contributor
sobolk
left a comment
sobolk
left a comment
There was a problem hiding this comment.
Please get green PR and E2E runs for this change.
- You may need to push some commit to trigger PR or kick off manually via
yarn cloud-pr - Use
yarn cloud-e2eto get e2e tests.
packages/amplify-util-uibuilder/src/commands/utils/codegen-ui-dependency-provider.ts
Show resolved
Hide resolved
packages/amplify-util-uibuilder/src/commands/utils/codegen-ui-dependency-provider.ts
Show resolved
Hide resolved
letsbelopez
reviewed
Sep 19, 2023
Jshhhh
force-pushed
the
remove-codegenui
branch
10 times, most recently
from
3ecfbe0 to
9ab5ba8
Compare
letsbelopez
previously approved these changes
Sep 26, 2023
sobolk
suggested changes
Sep 27, 2023
Contributor
sobolk
left a comment
sobolk
left a comment
There was a problem hiding this comment.
Please provide testing evidence as per previous comment.
Please update PR description and elaborate more about changes. A solid paragraph would be appropriate given complexity of the change.
Please fill out "Description of how you validated changes" section of PR description.
Contributor
Author
|
Description updated. |
Jshhhh
force-pushed
the
remove-codegenui
branch
from
9eade9e to
4d76058
Compare
sobolk
reviewed
Sep 28, 2023
Contributor
There was a problem hiding this comment.
Can you please add packages/amplify-util-builder to https://github.com/aws-amplify/amplify-cli/blob/dev/.github/CODEOWNERS and assign @aws-amplify/amplify-cli-admins AND your team ? Similarly how data team defined ownership ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Removes codegen-ui dependency from CLI. This doesn't change current behavior for ui component generation. The codegen-ui dependency is not needed anymore due to component codegen service.
Description of how you validated changes
Checklist
yarn testpassesyarn cloud-e2epassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.