-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling uncaughtException in create-amplify command #2364
base: main
Are you sure you want to change the base?
Handling uncaughtException in create-amplify command #2364
Conversation
🦋 Changeset detectedLatest commit: 416d4eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of duplicating a lot of the code here, you can move the existing error handling from cli
package to cli-core
package. Both create-amplify
and cli
have dependencies on the cli-core
package.
package-lock.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the diff for this lock file. It should not be needed for this PR.
31741ed
to
416d4eb
Compare
I really appreciate your comment. |
Re-open of #2045 because I mistakenly closed it.
Problem
Issue number, if available:
#825
Changes
In top-level error handling #865, parser and usageDataEmitter appears to be used for subcommands (e.g. ampx sandbox), so omit these parameters because
create-amplify
command are not followed by subcommandsCorresponding docs PR, if applicable:
Validation
error_handler.ts
and it's test cases are based on a similar issue fix top-level error handling #865Where should we create your project?
prompt causes no error.Checklist
run-e2e
label set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.