resultsdb-api support on 3.8 fix #6086
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resultsdb-api uses urllib as dependency. The urllib dropped support for the python 3.8 in the version 2.3.0. Let's use older version of urllib to keep python 3.8 support for resultsdb plugin. Reference: https://urllib3.readthedocs.io/en/stable/changelog.html#deprecations-and-removals Signed-off-by: Jan Richter <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6086 +/- ##
=========================================
Coverage ? 68.63%
=========================================
Files ? 202
Lines ? 21925
Branches ? 0
=========================================
Hits ? 15048
Misses ? 6877
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resultsdb-api uses urllib as dependency. The urllib dropped support for the python 3.8 in the version 2.3.0. Let's use older version of urllib to keep python 3.8 support for resultsdb plugin.
Reference:
https://urllib3.readthedocs.io/en/stable/changelog.html#deprecations-and-removals
This is a fix for CI failures like this one.